[GitHub] [incubator-tvm] tqchen commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

2020-06-05 Thread GitBox
tqchen commented on pull request #5730: URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639568074 @junrushao1994 we can also send a PR to add the comment about the consistency This is an automated message

[GitHub] [incubator-tvm] tqchen commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

2020-06-05 Thread GitBox
tqchen commented on pull request #5730: URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639567636 The kDLInt, kDLUInt, kDLFloat are still kept consistent with the original ArgType code. So downstream projects won't be affected. It will only affect type code after

[GitHub] [incubator-tvm] tqchen commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

2020-06-04 Thread GitBox
tqchen commented on pull request #5730: URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639143025 @zhiics Yes the DLPack changes are needed for the followup PRs to use bfloat16 This is an automated messag

[GitHub] [incubator-tvm] tqchen commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

2020-06-04 Thread GitBox
tqchen commented on pull request #5730: URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639000274 cc @zhiics @yzhliu @jroesch @junrushao1994 This is an automated message from the Apache Git Service. To re