[GitHub] [incubator-tvm] tqchen commented on pull request #5772: [ARITH]add simplify rule for div

2020-07-07 Thread GitBox
tqchen commented on pull request #5772: URL: https://github.com/apache/incubator-tvm/pull/5772#issuecomment-654944133 It would be great to elaborate your conditions in 1, and 2 a bit and write down a new rule :) I can double check a bit later

[GitHub] [incubator-tvm] tqchen commented on pull request #5772: [ARITH]add simplify rule for div

2020-07-06 Thread GitBox
tqchen commented on pull request #5772: URL: https://github.com/apache/incubator-tvm/pull/5772#issuecomment-654576484 @xqdan sorry for the delayed reply. I take a closer look, and unfortunately the new rules may not be correct. ``` TVM_TRY_REWRITE_IF( truncdiv(x +

[GitHub] [incubator-tvm] tqchen commented on pull request #5772: [ARITH]add simplify rule for div

2020-06-21 Thread GitBox
tqchen commented on pull request #5772: URL: https://github.com/apache/incubator-tvm/pull/5772#issuecomment-647258074 cc @spectrometerHBH @Hzfengsy would be great if you can also help to check the proof This is an

[GitHub] [incubator-tvm] tqchen commented on pull request #5772: [ARITH]add simplify rule for div

2020-06-19 Thread GitBox
tqchen commented on pull request #5772: URL: https://github.com/apache/incubator-tvm/pull/5772#issuecomment-646751495 Arith simplification are key to the correctness so it would be great if we can be extra careful here. It would be great if we can write down a proof for the rule, or at

[GitHub] [incubator-tvm] tqchen commented on pull request #5772: [ARITH]add simplify rule for div

2020-06-18 Thread GitBox
tqchen commented on pull request #5772: URL: https://github.com/apache/incubator-tvm/pull/5772#issuecomment-646354577 cc @zhiics @yongfeng-nv @merrymercy @jroesch please help to take a look This is an automated message from

[GitHub] [incubator-tvm] tqchen commented on pull request #5772: [ARITH]add simplify rule for div

2020-06-12 Thread GitBox
tqchen commented on pull request #5772: URL: https://github.com/apache/incubator-tvm/pull/5772#issuecomment-643343033 cc @yongfeng-nv @yzhliu @zhiics @wweic @junrushao1994 please help to take a look This is an automated