[GitHub] [incubator-tvm] tqchen edited a comment on issue #4628: [Object] Add String container

tqchen edited a comment on issue #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-584734563 @wweic please update per comments :) This is an automated message from the

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4628: [Object] Add String container

tqchen edited a comment on issue #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-583871162 @FrozenGene In general I agree that we should avoid std::experimental. In this particular case, i think the usage is fair, because it

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4628: [Object] Add String container

tqchen edited a comment on issue #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-583765522 @wweic here is a code snippet that we can reuse for hash. We should consider migrate to require c++14, which will give us string view support

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4628: [Object] Add String container

tqchen edited a comment on issue #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-583765522 @wweic here is an code snippet that we can reuse for hash. We should consider migrate to require c++14, which will give us string view support