[GitHub] [incubator-tvm] windclarion commented on pull request #5988: [TARGET] each option of target str should only contain one '='

2020-07-08 Thread GitBox
windclarion commented on pull request #5988: URL: https://github.com/apache/incubator-tvm/pull/5988#issuecomment-655847989 @ZihengJiang many other tests has tested tvm.build, ex. tests\python\integration\test_reduce.py test_reduce_prims Line64 has checked metal, vulkan, cuda, opencl, rocm

[GitHub] [incubator-tvm] windclarion commented on pull request #5988: [TARGET] each option of target str should only contain one '='

2020-07-07 Thread GitBox
windclarion commented on pull request #5988: URL: https://github.com/apache/incubator-tvm/pull/5988#issuecomment-654661434 today's test is flaky, I always failed at unexpected position This is an automated message from the Ap

[GitHub] [incubator-tvm] windclarion commented on pull request #5988: [TARGET] each option of target str should only contain one '='

2020-07-07 Thread GitBox
windclarion commented on pull request #5988: URL: https://github.com/apache/incubator-tvm/pull/5988#issuecomment-654658063 @junrushao1994 I add a small test which just test target wether can be created, and I just check the target shouldn't be None.

[GitHub] [incubator-tvm] windclarion commented on pull request #5988: [TARGET] each option of target str should only contain one '='

2020-07-06 Thread GitBox
windclarion commented on pull request #5988: URL: https://github.com/apache/incubator-tvm/pull/5988#issuecomment-654601466 @junrushao1994 What I have said maybe not very clear, I mean I can't catch a exception in python code, because C++ CHECK just abort, the abort function didn't thro

[GitHub] [incubator-tvm] windclarion commented on pull request #5988: [TARGET] each option of target str should only contain one '='

2020-07-06 Thread GitBox
windclarion commented on pull request #5988: URL: https://github.com/apache/incubator-tvm/pull/5988#issuecomment-654541003 @ZihengJiang I try to add test, but if I feed the option with a string which contains two '=', target_id.cc FindUniqueSubstr CHECK will abort, so I don't know how

[GitHub] [incubator-tvm] windclarion commented on pull request #5988: [TARGET] each option of target str should only contain one '='

2020-07-05 Thread GitBox
windclarion commented on pull request #5988: URL: https://github.com/apache/incubator-tvm/pull/5988#issuecomment-653973990 done! old code works ok before "[Target] Migrate data structure of TargetNode (#5960)", the commit add a requirement in src/target/target_id.cc. FindUniqueSubstr requ