[GitHub] [incubator-tvm] zhiics commented on pull request #6316: Dynamic Strided Slice

2020-09-08 Thread GitBox
zhiics commented on pull request #6316: URL: https://github.com/apache/incubator-tvm/pull/6316#issuecomment-689005174 Thanks @mbrookhart @yongwww @masahi @electriclilies This is an automated message from the Apache Git Servi

[GitHub] [incubator-tvm] zhiics commented on pull request #6316: Dynamic Strided Slice

2020-09-03 Thread GitBox
zhiics commented on pull request #6316: URL: https://github.com/apache/incubator-tvm/pull/6316#issuecomment-686643391 @masahi @electriclilies could you take another look and approve/comment? This is an automated message from

[GitHub] [incubator-tvm] zhiics commented on pull request #6316: Dynamic Strided Slice

2020-09-03 Thread GitBox
zhiics commented on pull request #6316: URL: https://github.com/apache/incubator-tvm/pull/6316#issuecomment-686642705 @mbrookhart no problem BTW, I would suggest moving the compute to topi and make dynamic version there in the next PR. Do we need to change the topi strided_slice defi

[GitHub] [incubator-tvm] zhiics commented on pull request #6316: Dynamic Strided Slice

2020-09-02 Thread GitBox
zhiics commented on pull request #6316: URL: https://github.com/apache/incubator-tvm/pull/6316#issuecomment-686223297 @mbrookhart please rebase This is an automated message from the Apache Git Service. To respond to the messa