zhiics commented on pull request #6395:
URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-712488241
Thanks @trevor-m @comaniac @lhutton1 @leandron
This is an automated message from the Apache Git Service.
T
zhiics commented on pull request #6395:
URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-707922105
I think we can enable the test and merge after #6679 is landed since its
pretty close already?
This is an
zhiics commented on pull request #6395:
URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-707390645
I agree that we can merge it first. But before that, @trevor-m could you
rebase against the master and run the tests again locally to see if all of them
pass? I am not sure
zhiics commented on pull request #6395:
URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-704464026
@lhutton1 @leandron please take another look per
https://tvm.apache.org/docs/contribute/code_review.html#approve-and-request-changes-explicitly
---
zhiics commented on pull request #6395:
URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-695094226
cc @wpan11nv this might be something you or some of your Nvidia forks
interested.
This is an automated mes
zhiics commented on pull request #6395:
URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-692328667
> > Hmm, this seems like it would make the job of the
`PruneTensorRTSubgraph` pass much more difficult. `PartitionGraph` already
takes care of collecting the inputs and out
zhiics commented on pull request #6395:
URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-686779607
@trevor-m @masahi for the pass config, we may not be able to obtain at the
runtime though
This is an autom
zhiics commented on pull request #6395:
URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-686739951
Usually we need a separate PR to install the library/environment in the CI
first (TRT in this case) so that we can have better e2e tests.
zhiics commented on pull request #6395:
URL: https://github.com/apache/incubator-tvm/pull/6395#issuecomment-686726858
cc @comaniac @mbaret @lhutton1 @masahi @leandron @mbrookhart
This is an automated message from the Apache
