[GitHub] [tvm] FrozenGene commented on a change in pull request #8223: support adb-shell style cpp_rpc

2021-06-14 Thread GitBox
FrozenGene commented on a change in pull request #8223: URL: https://github.com/apache/tvm/pull/8223#discussion_r651470581 ## File path: apps/cpp_rpc/rpc_env.cc ## @@ -95,7 +96,16 @@ RPCEnv::RPCEnv(const std::string& wd) { auto cmdline = fopen("/proc/self/cmdline", "r");

[GitHub] [tvm] FrozenGene commented on a change in pull request #8223: support adb-shell style cpp_rpc

2021-06-09 Thread GitBox
FrozenGene commented on a change in pull request #8223: URL: https://github.com/apache/tvm/pull/8223#discussion_r648799216 ## File path: apps/cpp_rpc/rpc_env.cc ## @@ -95,7 +95,13 @@ RPCEnv::RPCEnv(const std::string& wd) { auto cmdline = fopen("/proc/self/cmdline", "r");

[GitHub] [tvm] FrozenGene commented on a change in pull request #8223: support adb-shell style cpp_rpc

2021-06-09 Thread GitBox
FrozenGene commented on a change in pull request #8223: URL: https://github.com/apache/tvm/pull/8223#discussion_r648798469 ## File path: .gitignore ## @@ -197,6 +197,7 @@ tvm_t.* .pytest_cache .local cmake-build-debug +cmake-build* Review comment: Yes, if you think

[GitHub] [tvm] FrozenGene commented on a change in pull request #8223: support adb-shell style cpp_rpc

2021-06-09 Thread GitBox
FrozenGene commented on a change in pull request #8223: URL: https://github.com/apache/tvm/pull/8223#discussion_r648788698 ## File path: apps/cpp_rpc/rpc_env.cc ## @@ -95,7 +95,13 @@ RPCEnv::RPCEnv(const std::string& wd) { auto cmdline = fopen("/proc/self/cmdline", "r");

[GitHub] [tvm] FrozenGene commented on a change in pull request #8223: support adb-shell style cpp_rpc

2021-06-09 Thread GitBox
FrozenGene commented on a change in pull request #8223: URL: https://github.com/apache/tvm/pull/8223#discussion_r648786905 ## File path: .gitignore ## @@ -197,6 +197,7 @@ tvm_t.* .pytest_cache .local cmake-build-debug +cmake-build* Review comment: your pr should not