[GitHub] [tvm] Lunderberg commented on pull request #7867: [Runtime] Driver version + consistent clock speed units

2021-04-21 Thread GitBox
Lunderberg commented on pull request #7867: URL: https://github.com/apache/tvm/pull/7867#issuecomment-824194789 @areusch Good point, and that is useful feedback. Changes made in each docstring to indicate that they can return `None`. The one exception is `.exist`, which returns a boolean

[GitHub] [tvm] Lunderberg commented on pull request #7867: [Runtime] Driver version + consistent clock speed units

2021-04-20 Thread GitBox
Lunderberg commented on pull request #7867: URL: https://github.com/apache/tvm/pull/7867#issuecomment-823426181 One more commit to address the CI failure. I had been using the newer unified opencl header files, where the CI has the earlier version-specific header files. -- This is an a

[GitHub] [tvm] Lunderberg commented on pull request #7867: [Runtime] Driver version + consistent clock speed units

2021-04-19 Thread GitBox
Lunderberg commented on pull request #7867: URL: https://github.com/apache/tvm/pull/7867#issuecomment-822749420 Thank you, @masahi . Looks like the conflict was due to additional rebasing needed. @areusch , I've added additional documentation on the `.driver_version` property, alon

[GitHub] [tvm] Lunderberg commented on pull request #7867: [Runtime] Driver version + consistent clock speed units

2021-04-16 Thread GitBox
Lunderberg commented on pull request #7867: URL: https://github.com/apache/tvm/pull/7867#issuecomment-821397971 Potential reviewers: @hogepodge for the documentation changes, or @masahi / @areusch / @tmoreau89 for runtime changes. -- This is an automated message from the Apache Git Serv