[GitHub] [tvm] Lunderberg commented on pull request #8010: [UnitTests] Automatic parametrization over targets, with explicit opt-out

2021-06-22 Thread GitBox
Lunderberg commented on pull request #8010: URL: https://github.com/apache/tvm/pull/8010#issuecomment-866401356 @jwfromm And added meta-tests for all the new functionality. @tmoreau89 Good point, that was an intentional choice to point to the main branch of tvm-rfcs. I figured that

[GitHub] [tvm] Lunderberg commented on pull request #8010: [UnitTests] Automatic parametrization over targets, with explicit opt-out

2021-06-22 Thread GitBox
Lunderberg commented on pull request #8010: URL: https://github.com/apache/tvm/pull/8010#issuecomment-866309879 @jwfromm That's a good point. I had initially thought that there were few enough features that they could be implicitly tested by their use in other tests, but with the

[GitHub] [tvm] Lunderberg commented on pull request #8010: [UnitTests] Automatic parametrization over targets, with explicit opt-out

2021-06-09 Thread GitBox
Lunderberg commented on pull request #8010: URL: https://github.com/apache/tvm/pull/8010#issuecomment-858150839 Added one more bugfix. First implementation of removing fixture functions from module scope was a bit overzealous, also removed any objects that implement `__getattr__`, such

[GitHub] [tvm] Lunderberg commented on pull request #8010: [UnitTests] Automatic parametrization over targets, with explicit opt-out

2021-06-01 Thread GitBox
Lunderberg commented on pull request #8010: URL: https://github.com/apache/tvm/pull/8010#issuecomment-852213741 Rebased on main to start CI again, now that the CI fix #8160 is in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to