Lunderberg opened a new pull request, #12726:
URL: https://github.com/apache/tvm/pull/12726

   Previously, it was ambiguous whether `BlockNode::iter_vars` were in-scope 
for `BlockRealizeNode::predicate`.  `ConvertBlocksToOpaque` treated them as 
in-scope, and applied a mapping from `iter_vars` to `iter_values`.  Similarly, 
TVMScript printing places `T.where` statements below the `T.axis` statements, 
where `T.axis` definitions are in scope.  However, 
`BlockRealizeNode::SEqualReduce` and `BlockRealizeNode::SHashReduce` do not 
visit the block and `iter_vars` until after visiting the predicate, placing the 
`iter_vars` out of scope.
   
   This commit updates the printing of `T.where` to be above `T.axis`, and 
updates `ConvertBlocksToOpaque` to report an error if the predicate contains 
references to `BlockNode::iter_vars`.  After this commit, these three usages 
all consistently treat
   `BlockNode::iter_vars` as out of scope for `BlockRealizeNode::predicate`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to