[GitHub] [tvm] Mousius commented on pull request #8835: Change target string to Target object in the TE compiler and interpreter

2021-08-25 Thread GitBox
Mousius commented on pull request #8835: URL: https://github.com/apache/tvm/pull/8835#issuecomment-905584474 Hmm, I picked on it calling into that block within `LowerTE` before the `shape_target` existed via this call: ``` std::pair> main_and_lowered = Prepare(mod_and_globa

[GitHub] [tvm] Mousius commented on pull request #8835: Change target string to Target object in the TE compiler and interpreter

2021-08-25 Thread GitBox
Mousius commented on pull request #8835: URL: https://github.com/apache/tvm/pull/8835#issuecomment-905352332 Hmm, something weird is occurring here, unsure why those tests didn't run for me locally - but debugging `test_any.py` a bit I ran `tvm::Dump(per_target_module_)` and got (removed f

[GitHub] [tvm] Mousius commented on pull request #8835: Change target string to Target object in the TE compiler and interpreter

2021-08-24 Thread GitBox
Mousius commented on pull request #8835: URL: https://github.com/apache/tvm/pull/8835#issuecomment-904848171 This is amazing @electriclilies, this is a much cleaner representation of the `Target`s, thanks for doing this :smile_cat: -- This is an automated message from the Apache Git Ser