[GitHub] [tvm] Qianshui-Jiang commented on pull request #11638: [DNNL][CBLAS][BYOC] Unifles all MKLDNN/DNNL to DNNL

2022-06-10 Thread GitBox
Qianshui-Jiang commented on PR #11638: URL: https://github.com/apache/tvm/pull/11638#issuecomment-1152502145 > > Does it need to emit a reminding log that we are moving to new flag of `dnnl` at the same time we supporting `-libs=mkldnn`? > > yeah let's do that. Rebased and upda

[GitHub] [tvm] Qianshui-Jiang commented on pull request #11638: [DNNL][CBLAS][BYOC] Unifles all MKLDNN/DNNL to DNNL

2022-06-10 Thread GitBox
Qianshui-Jiang commented on PR #11638: URL: https://github.com/apache/tvm/pull/11638#issuecomment-1152135838 @masahi I commit a change of tvm target, pls take a look , and could you pls merge #11571 at first so that I can update them all toghther in this PR -- This is an automated me

[GitHub] [tvm] Qianshui-Jiang commented on pull request #11638: [DNNL][CBLAS][BYOC] Unifles all MKLDNN/DNNL to DNNL

2022-06-09 Thread GitBox
Qianshui-Jiang commented on PR #11638: URL: https://github.com/apache/tvm/pull/11638#issuecomment-1151709701 > This seems like a breaking change for users using `-libs=mkldnn`. Can you still support `-libs=mkldnn` but translate that to `-libs=dnnl`? Sure, good idea. Does it need t

[GitHub] [tvm] Qianshui-Jiang commented on pull request #11638: [DNNL][CBLAS][BYOC] Unifles all MKLDNN/DNNL to DNNL

2022-06-09 Thread GitBox
Qianshui-Jiang commented on PR #11638: URL: https://github.com/apache/tvm/pull/11638#issuecomment-1150845327 @masahi @areusch could you pls take a review and comments if need to be refined? -- This is an automated message from the Apache Git Service. To respond to the message, please l