[GitHub] [tvm] adstraw commented on pull request #11653: [Hexagon] Add HexagonThreadManager

2022-06-10 Thread GitBox
adstraw commented on PR #11653: URL: https://github.com/apache/tvm/pull/11653#issuecomment-1152762287 Just a reminder that CI is failing because it requires this PR https://github.com/apache/tvm/pull/11635 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] adstraw commented on pull request #11653: [Hexagon] Add HexagonThreadManager

2022-06-10 Thread GitBox
adstraw commented on PR #11653: URL: https://github.com/apache/tvm/pull/11653#issuecomment-1152758033 Just realized that I named my commit "static cast for TVMStreamHandle` before I realized that reinterpret_cast was required. I can rename that commit or ... Just thinking out loud h

[GitHub] [tvm] adstraw commented on pull request #11653: [Hexagon] Add HexagonThreadManager

2022-06-10 Thread GitBox
adstraw commented on PR #11653: URL: https://github.com/apache/tvm/pull/11653#issuecomment-1152723692 > The (TVMStreamHandle)i is still there. It's not that much of a big deal, but it would be nice to replace it with static_cast eventually. Missed this. Will fix. -- This is an aut

[GitHub] [tvm] adstraw commented on pull request #11653: [Hexagon] Add HexagonThreadManager

2022-06-09 Thread GitBox
adstraw commented on PR #11653: URL: https://github.com/apache/tvm/pull/11653#issuecomment-1151717231 > Could you move the buffer manager changes to a separate PR? They seem independent from the thread manager. I am basically moving this functionality from within the Hexagon Device AP