[GitHub] [tvm] alanmacd commented on issue #11414: [Tracking Issue] pylint the tests!

2022-07-11 Thread GitBox
alanmacd commented on issue #11414: URL: https://github.com/apache/tvm/issues/11414#issuecomment-1181110122 @Mousius Thanks, that works! It was slightly more complicated, but I think I figured it out. 😄 `@pytest.mark.parametrize("enable_usmp,expect_exception", [(True, True), (Fal

[GitHub] [tvm] alanmacd commented on issue #11414: [Tracking Issue] pylint the tests!

2022-07-10 Thread GitBox
alanmacd commented on issue #11414: URL: https://github.com/apache/tvm/issues/11414#issuecomment-1179806181 Has anyone found a way to address the **redefined-outer-name** warning when **tvm.testing.parameters** is used? For example see [test_crt.py::test_aot_executor_usmp_const_pool](https:

[GitHub] [tvm] alanmacd commented on issue #11414: [Tracking Issue] pylint the tests!

2022-06-16 Thread GitBox
alanmacd commented on issue #11414: URL: https://github.com/apache/tvm/issues/11414#issuecomment-1157936309 One recommendation, based on my past experience with large linting or security scan efforts is to open a work item for areas that aren't easily resolved, and leave a comment with the

[GitHub] [tvm] alanmacd commented on issue #11414: [Tracking Issue] pylint the tests!

2022-06-15 Thread GitBox
alanmacd commented on issue #11414: URL: https://github.com/apache/tvm/issues/11414#issuecomment-1156739720 > **tvm.testing.fixture()** Unfortunately, in my case, it's using tvm.testing.fixture() not @pytest.fixture() so I can't use the **name** workaround. I also don't see how remov

[GitHub] [tvm] alanmacd commented on issue #11414: [Tracking Issue] pylint the tests!

2022-06-14 Thread GitBox
alanmacd commented on issue #11414: URL: https://github.com/apache/tvm/issues/11414#issuecomment-1155770187 I also hit an issue in [tests/python/unittest/test_micro_project_api.py](https://github.com/apache/tvm/blob/main/tests/python/unittest/test_micro_project_api.py) related to pytest fix

[GitHub] [tvm] alanmacd commented on issue #11414: [Tracking Issue] pylint the tests!

2022-06-14 Thread GitBox
alanmacd commented on issue #11414: URL: https://github.com/apache/tvm/issues/11414#issuecomment-1155596426 @AndrewZhaoLuo agreed, additionally, pylint seems to be inconsistent as far as which one character variable names it allows and which it doesn't. -- This is an automated message fro

[GitHub] [tvm] alanmacd commented on issue #11414: [Tracking Issue] pylint the tests!

2022-06-10 Thread GitBox
alanmacd commented on issue #11414: URL: https://github.com/apache/tvm/issues/11414#issuecomment-1152722209 I'll start with these: ``` tests/python/unittest/test_crt.py tests/python/unittest/test_micro_model_library_format.py tests/python/unittest/test_micro_project_api.py