csullivan commented on a change in pull request #9343:
URL: https://github.com/apache/tvm/pull/9343#discussion_r733974649
##########
File path: apps/hexagon_launcher/README.md
##########
@@ -40,29 +40,32 @@ tvm_runtime, as well as the Hexagon launcher shared library
and its correspondin
tvm_runtime. As described in the [Manual compilation](#Manual compilation)
section
each component requires Hexagon and android dependencies. When building the
launcher
along with TVM these configurations must be providing when invoking cmake. A
minimal
-example invocation for compiling TVM along with the Hexagon launcher is
included below,
+example invocation for compiling TVM along with the Hexagon launcher is
included below:
```
-cmake -DCMAKE_MAKE_PROGRAM=make \
- -DCMAKE_C_COMPILER=clang \
- -DCMAKE_CXX_COMPILER=clang++ \
+cmake -DCMAKE_C_COMPILER=/path/to/clang \
+ -DCMAKE_CXX_COMPILER=/path/to/clang++ \
-DCMAKE_CXX_FLAGS='-stdlib=libc++' \
-DCMAKE_CXX_STANDARD=14 \
- -DUSE_LLVM=/path/to/hexagon/llvm/bin/llvm-config \
+ -DUSE_LLVM=/path/to/llvm/bin/llvm-config \
Review comment:
I had the `/path/to/hexagon` prefix to indicate the llvm libs need to
have hexagon codegen support. Perhaps this would be worth noting in the text
below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
