[GitHub] [tvm] csullivan commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-26 Thread GitBox
csullivan commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r956442755 ## src/runtime/hexagon/hexagon_user_dma.h: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] csullivan commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-25 Thread GitBox
csullivan commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r955115733 ## tests/cpp-runtime/hexagon/ring_buffer_tests.cc: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [tvm] csullivan commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-22 Thread GitBox
csullivan commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r952001668 ## src/runtime/hexagon/hexagon_user_dma.cc: ## @@ -82,12 +95,13 @@ int HexagonUserDMA::Copy(void* dst, void* src, uint32_t length) { dmstart(dma_desc);

[GitHub] [tvm] csullivan commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-22 Thread GitBox
csullivan commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r951993684 ## tests/cpp-runtime/hexagon/hexagon_user_dma_tests.cc: ## @@ -57,9 +57,9 @@ TEST_F(HexagonUserDMATest, wait) { HexagonUserDMA::Get().Wait(10); } Review Comment:

[GitHub] [tvm] csullivan commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-17 Thread GitBox
csullivan commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r948483578 ## src/runtime/hexagon/hexagon_user_dma.cc: ## @@ -90,32 +78,80 @@ int hexagon_user_dma_1d_sync_helper(void* dst, void* src, uint32_t length) {