[GitHub] [tvm] csullivan commented on pull request #13325: [TRANSFORM] Fix virtual device annotation issue with BYOC subgraphs

2022-11-29 Thread GitBox
csullivan commented on PR #13325: URL: https://github.com/apache/tvm/pull/13325#issuecomment-1331015785 cc @echuraev @elvin-n does this change look good to you and pass internal texture tests? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [tvm] csullivan commented on pull request #13325: [TRANSFORM] Fix virtual device annotation issue with BYOC subgraphs

2022-11-08 Thread GitBox
csullivan commented on PR #13325: URL: https://github.com/apache/tvm/pull/13325#issuecomment-1307976117 Hi @srkreddy1238, I didn't quite understand the conclusion you make, > PushVirtualDevice and PopVirtualDevice occurs as pairs across function body, **hence it's better to insert t