[GitHub] [tvm] grant-arm commented on pull request #8720: Sanitize names of input tensors in interface header

2021-09-01 Thread GitBox
grant-arm commented on pull request #8720: URL: https://github.com/apache/tvm/pull/8720#issuecomment-910690442 Hi @areusch , would you mind taking a look at this again and see whether you're happy with the change I made to address the case where multiple tensor names with punctuation are i

[GitHub] [tvm] grant-arm commented on pull request #8720: Sanitize names of input tensors in interface header

2021-08-20 Thread GitBox
grant-arm commented on pull request #8720: URL: https://github.com/apache/tvm/pull/8720#issuecomment-902812246 > @grant-arm @manupa-arm @Mousius sorry for the late review here. i do think we need to consider the case that multiple distinct punctuation are mangled into identical variable na

[GitHub] [tvm] grant-arm commented on pull request #8720: Sanitize names of input tensors in interface header

2021-08-19 Thread GitBox
grant-arm commented on pull request #8720: URL: https://github.com/apache/tvm/pull/8720#issuecomment-902068460 Thanks for the comments @mbs-octoml . I've added a TODO to the code now that references the issue that @Mousius created. -- This is an automated message from the Apache Git Serv