guberti commented on PR #13051:
URL: https://github.com/apache/tvm/pull/13051#issuecomment-1284212732
Thanks for the review @areusch! Your comments should be addressed by fed35c2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
guberti commented on PR #13051:
URL: https://github.com/apache/tvm/pull/13051#issuecomment-1278650369
@mehrdadh thanks for explaining, that makes sense. Tests should pass now,
would you mind reviewing and merging?
--
This is an automated message from the Apache Git Service.
To respond to
guberti commented on PR #13051:
URL: https://github.com/apache/tvm/pull/13051#issuecomment-1277405932
Thanks for the review @mkatanbaf! I'm a big fan of the current test runner
and of the `AOTTestModule` and `compile_and_run` helper functions - they've
proven to be stable, and when running
guberti commented on PR #13051:
URL: https://github.com/apache/tvm/pull/13051#issuecomment-1275918393
When reorganizing the tests, I noticed there was duplicate code in tests
besides the `conv2d` ones. Each file has its own calls to
`relay.op.nn.[operator]`, which are constructed the same w
