[GitHub] [tvm] insop commented on pull request #7111: Fix a bug in batch_matmul that te.max should be used

2020-12-17 Thread GitBox
insop commented on pull request #7111: URL: https://github.com/apache/tvm/pull/7111#issuecomment-747915428 @comaniac , @zhiics PTLA. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] insop commented on pull request #7111: Fix a bug in batch_matmul that te.max should be used

2020-12-17 Thread GitBox
insop commented on pull request #7111: URL: https://github.com/apache/tvm/pull/7111#issuecomment-747862949 @tsupei, I didn't see it on my system where it only ran `llvm` test. I have this [patch](https://github.com/insop/incubator-tvm/commit/8c0e1d7351cb5860e159cc29a51204525aa0283

[GitHub] [tvm] insop commented on pull request #7111: Fix a bug in batch_matmul that te.max should be used

2020-12-16 Thread GitBox
insop commented on pull request #7111: URL: https://github.com/apache/tvm/pull/7111#issuecomment-747196507 @tsupei There was a clang-format check fali, here is another [patch](https://github.com/insop/incubator-tvm/commit/f98c5db737ecac5bd2bf4df0204299cb88108978.patch). Thank

[GitHub] [tvm] insop commented on pull request #7111: Fix a bug in batch_matmul that te.max should be used

2020-12-16 Thread GitBox
insop commented on pull request #7111: URL: https://github.com/apache/tvm/pull/7111#issuecomment-745979049 @tsupei , @zhiics How about this? by this, we can test. Patch is [here](https://github.com/insop/incubator-tvm/commit/9b7b1589f4a05a739e19652b7a2705e4bfc7bfcb.patch).

[GitHub] [tvm] insop commented on pull request #7111: Fix a bug in batch_matmul that te.max should be used

2020-12-15 Thread GitBox
insop commented on pull request #7111: URL: https://github.com/apache/tvm/pull/7111#issuecomment-745162449 @tsupei Sorry, one of my change in `python/tvm/topi/testing/batch_matmul.py` file need to reverted, since this was for getting reference result using `numpy`. I tested this

[GitHub] [tvm] insop commented on pull request #7111: Fix a bug in batch_matmul that te.max should be used

2020-12-14 Thread GitBox
insop commented on pull request #7111: URL: https://github.com/apache/tvm/pull/7111#issuecomment-745054063 1. @tsupei Good fix, you might want to `git am` [this patch file](https://github.com/insop/incubator-tvm/commit/79e8cf5b24e5170fbfc51461249425ad6b868a7c.patch) to fix other locations