[GitHub] [tvm] junrushao commented on a diff in pull request #12450: [TIR][Schedule] enhance compute_at and reverse_compute_at primitive to choose possible position

2022-08-25 Thread GitBox
junrushao commented on code in PR #12450: URL: https://github.com/apache/tvm/pull/12450#discussion_r955645217 ## src/tir/schedule/primitive/compute_at.cc: ## @@ -585,10 +603,11 @@ void ComputeAtOrReverseComputeAtImpl(ScheduleState self, const StmtSRef& block_s

[GitHub] [tvm] junrushao commented on a diff in pull request #12450: [TIR][Schedule] enhance compute_at and reverse_compute_at primitive to choose possible position

2022-08-25 Thread GitBox
junrushao commented on code in PR #12450: URL: https://github.com/apache/tvm/pull/12450#discussion_r955645029 ## src/tir/schedule/primitive/compute_at.cc: ## @@ -159,8 +162,22 @@ int FindInsertionPoint( // Step 3. Check if there is at least one index of the position can be

[GitHub] [tvm] junrushao commented on a diff in pull request #12450: [TIR][Schedule] enhance compute_at and reverse_compute_at primitive to choose possible position

2022-08-25 Thread GitBox
junrushao commented on code in PR #12450: URL: https://github.com/apache/tvm/pull/12450#discussion_r955644837 ## src/tir/schedule/primitive.h: ## @@ -299,10 +299,12 @@ TVM_DLL StmtSRef ReIndex(ScheduleState self, const StmtSRef& block_sref, int buf * \param self The schedule

[GitHub] [tvm] junrushao commented on a diff in pull request #12450: [TIR][Schedule] enhance compute_at and reverse_compute_at primitive to choose possible position

2022-08-25 Thread GitBox
junrushao commented on code in PR #12450: URL: https://github.com/apache/tvm/pull/12450#discussion_r955644743 ## python/tvm/tir/schedule/schedule.py: ## @@ -1303,6 +1304,11 @@ def compute_at( preserve_unit_loops: bool Whether to keep the trivial loops