[GitHub] [tvm] junrushao1994 commented on pull request #8775: Remove compile_engine.h for real this time.

2021-08-20 Thread GitBox
junrushao1994 commented on pull request #8775: URL: https://github.com/apache/tvm/pull/8775#issuecomment-903023408 Okay, I didn’t see any actual conflict here. Shall we just add a few helpers and proceed? -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [tvm] junrushao1994 commented on pull request #8775: Remove compile_engine.h for real this time.

2021-08-19 Thread GitBox
junrushao1994 commented on pull request #8775: URL: https://github.com/apache/tvm/pull/8775#issuecomment-902117888 @comaniac This proposal sounds good to me, in terms of minimal API change and being consistent with the TE compiler’s design philosophy @jroesch Would you like to take

[GitHub] [tvm] junrushao1994 commented on pull request #8775: Remove compile_engine.h for real this time.

2021-08-19 Thread GitBox
junrushao1994 commented on pull request #8775: URL: https://github.com/apache/tvm/pull/8775#issuecomment-901778600 As the moderator in this thread, I do expect sufficient discussion as an architectural change. Let’s keep the discussion purely technical as we always enjoy in the community :

[GitHub] [tvm] junrushao1994 commented on pull request #8775: Remove compile_engine.h for real this time.

2021-08-18 Thread GitBox
junrushao1994 commented on pull request #8775: URL: https://github.com/apache/tvm/pull/8775#issuecomment-901367404 Thanks @comaniac for the list! It is definitely helpful for narrowing down the scope for discussion. Looks like we are pretty close to a solution to hot-swap the out-of-tree i

[GitHub] [tvm] junrushao1994 commented on pull request #8775: Remove compile_engine.h for real this time.

2021-08-18 Thread GitBox
junrushao1994 commented on pull request #8775: URL: https://github.com/apache/tvm/pull/8775#issuecomment-900708410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [tvm] junrushao1994 commented on pull request #8775: Remove compile_engine.h for real this time.

2021-08-17 Thread GitBox
junrushao1994 commented on pull request #8775: URL: https://github.com/apache/tvm/pull/8775#issuecomment-900844754 @jroesch @comaniac @icemelon you guys can discuss together without me :-) I am very supportive of the new lowering process, which makes the logic much clearer, but aware of th

[GitHub] [tvm] junrushao1994 commented on pull request #8775: Remove compile_engine.h for real this time.

2021-08-17 Thread GitBox
junrushao1994 commented on pull request #8775: URL: https://github.com/apache/tvm/pull/8775#issuecomment-900837649 I know there is strong dependency to compile engine in other projects, and would love to propose several actions we could take to make sure the process working properly for bo

[GitHub] [tvm] junrushao1994 commented on pull request #8775: Remove compile_engine.h for real this time.

2021-08-17 Thread GitBox
junrushao1994 commented on pull request #8775: URL: https://github.com/apache/tvm/pull/8775#issuecomment-900731239 I know there is some dependency on the relay compile engine in some other projects. Shall we slow down a little bit and wait for some consensus? Thanks a lot! -- This is an

[GitHub] [tvm] junrushao1994 commented on pull request #8775: Remove compile_engine.h for real this time.

2021-08-17 Thread GitBox
junrushao1994 commented on pull request #8775: URL: https://github.com/apache/tvm/pull/8775#issuecomment-900708410 CC @icemelon @comaniac @yzhliu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to