kparzysz-quic commented on pull request #8213:
URL: https://github.com/apache/tvm/pull/8213#issuecomment-858681736
What else needs to be done for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kparzysz-quic commented on pull request #8213:
URL: https://github.com/apache/tvm/pull/8213#issuecomment-858034729
I've been using the entire clang toolchain built with assertions (the
Release+Assertions build) in my daily work and I don't find it too slow.
Frankly, I'm not sure if I
kparzysz-quic commented on pull request #8213:
URL: https://github.com/apache/tvm/pull/8213#issuecomment-857166287
I think I know what's going on: if you use LLVM that was compiled without
assertions, it may not crash at the time of generating the LLVM IR. I guess
that the generated LLVM
kparzysz-quic commented on pull request #8213:
URL: https://github.com/apache/tvm/pull/8213#issuecomment-857150051
The test `tests/python/unittest/test_link_params.py` fails without this
patch. How come it wasn't failing in the CI?
--
This is an automated message from the Apache Git
kparzysz-quic commented on pull request #8213:
URL: https://github.com/apache/tvm/pull/8213#issuecomment-856972609
The above assertion is because the program tried to get a pointer to `void`
in LLVM. There is no such thing, hence the assertion. After you fix that, you
hit another
kparzysz-quic commented on pull request #8213:
URL: https://github.com/apache/tvm/pull/8213#issuecomment-856963214
This is the assertion that I'm getting without this patch:
```
python3: /w/src/llvm-project/llvm/lib/IR/Type.cpp:689: static
llvm::PointerType
kparzysz-quic commented on pull request #8213:
URL: https://github.com/apache/tvm/pull/8213#issuecomment-856956704
If you use LLVM with assertions enabled, it will simply not allow you to
create such a bitcast: attempt to do so will trigger an assertion.
--
This is an automated message
kparzysz-quic commented on pull request #8213:
URL: https://github.com/apache/tvm/pull/8213#issuecomment-856930673
The generated LLVM IR was not valid: for example it had bitcasts between
pointer and array types.
--
This is an automated message from the Apache Git Service.
To respond to
