kparzysz-quic opened a new pull request, #12123: URL: https://github.com/apache/tvm/pull/12123
LLVMModule has two members that refer to llvm::Module: 1. llvm::Module* mptr_, and 2. std::unique_ptr\<llvm::Module\> module_. The mptr_ member is always valid and it points to the llvm::Module. The unique pointer takes care of the ownership of the llvm::Module, and deletes it when no longer needed. However, once JIT is initialized, it takes over the ownership of the llvm::Module, and the module_ member becomes null. To avoid checks for null, use the raw pointer whenever accessing the llvm::Module, and only use the unique_ptr as the owner/deleter. The member names are changes to reflect their roles: - module_ -> module_owning_ptr_ - mptr_ -> module_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
