leandron commented on code in PR #12555:
URL: https://github.com/apache/tvm/pull/12555#discussion_r955147503
##########
tests/python/frontend/onnx/test_forward.py:
##########
@@ -2027,6 +2027,7 @@ def verify_pad_v11(indata, pads, mode="constant",
value=0.0):
verify_pad_v11(np.random.randn(2, 2).astype(np.float32), [0, 1, 0, 0],
"constant", 0.0)
verify_pad_v11(np.random.randn(2, 3).astype(np.float32), [1, 0, 0, 1],
"constant", 0.0)
verify_pad_v11(np.random.randn(3, 2).astype(np.float32), [0, 0, 1, 0],
"constant", 5.0)
+ verify_pad_v11(np.random.randn(3, 2).astype(np.float32), [0, 0, 1, 0],
"constant", False)
Review Comment:
Is setting `False` here (as opposed to `None`) reproducing the same issue
this patch is fixing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
