[GitHub] [tvm] lhutton1 edited a comment on pull request #9299: [microNPU] Fix typo in depthwise to allow int8 weights

lhutton1 edited a comment on pull request #9299: URL: https://github.com/apache/tvm/pull/9299#issuecomment-953751034 Thanks for the discussion @Mousius @ekalda, I've added a test for incompatible weight data types to get this patch in. However, I do wonder whether this implies every assert

[GitHub] [tvm] lhutton1 edited a comment on pull request #9299: [microNPU] Fix typo in depthwise to allow int8 weights

lhutton1 edited a comment on pull request #9299: URL: https://github.com/apache/tvm/pull/9299#issuecomment-948626646 Hi @Mousius, yes, currently you can remove `ICHECK` without affecting the tests. However, I'm not too sure I follow. I understand `ICHECK` is an assertion. A test cou

[GitHub] [tvm] lhutton1 edited a comment on pull request #9299: [microNPU] Fix typo in depthwise to allow int8 weights

lhutton1 edited a comment on pull request #9299: URL: https://github.com/apache/tvm/pull/9299#issuecomment-948626646 Hi @Mousius, yes, currently you can remove `ICHECK` without affecting the tests. However, I'm not too sure I follow. I understand `ICHECK` is an assertion. A test cou

[GitHub] [tvm] lhutton1 edited a comment on pull request #9299: [microNPU] Fix typo in depthwise to allow int8 weights

lhutton1 edited a comment on pull request #9299: URL: https://github.com/apache/tvm/pull/9299#issuecomment-948626646 Hi @Mousius, yes, currently you can remove `ICHECK` without affecting the tests, since we only test legal combinations of input datatypes at this level. However, I'm n