[GitHub] [tvm] manupak commented on pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer

2022-09-27 Thread GitBox
manupak commented on PR #12880: URL: https://github.com/apache/tvm/pull/12880#issuecomment-1260143073 to clarify a bit more -- I just meant to say, according to https://github.com/apache/tvm/blob/main/docs/contribute/pull_request.rst, we might want to put a textual description in here in

[GitHub] [tvm] manupak commented on pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer

2022-09-27 Thread GitBox
manupak commented on PR #12880: URL: https://github.com/apache/tvm/pull/12880#issuecomment-1260054391 I think we need a commit message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] manupak commented on pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer

2022-09-26 Thread GitBox
manupak commented on PR #12880: URL: https://github.com/apache/tvm/pull/12880#issuecomment-1257720475 Thanks for the fix -- yea I double checked whether buffer info extraction captures this scenario as well -- it seems so. If we can get the tests and LOG(INFO)s removed -- I think we cant

[GitHub] [tvm] manupak commented on pull request #12880: [usmp] Also remap VarNode to USMP-allocated buffer

2022-09-23 Thread GitBox
manupak commented on PR #12880: URL: https://github.com/apache/tvm/pull/12880#issuecomment-1256338295 H... I suppose this scenario want to pass a buffer itself to the call (as opposed to a BufferLoad) ? -- This is an automated message from the Apache Git Service. To respond to the