[GitHub] [tvm] masahi commented on a diff in pull request #14440: [Unity][Graph matching] Clean up undo stack for parent and child nodes properly

2023-03-30 Thread via GitHub
masahi commented on code in PR #14440: URL: https://github.com/apache/tvm/pull/14440#discussion_r1153887847 ## src/relax/ir/dataflow_matcher.cc: ## @@ -540,33 +541,48 @@ struct RNode { /** * \brief This method try to match a real node and a pattern node along with its neighb

[GitHub] [tvm] masahi commented on a diff in pull request #14440: [Unity][Graph matching] Clean up undo stack for parent and child nodes properly

2023-03-30 Thread via GitHub
masahi commented on code in PR #14440: URL: https://github.com/apache/tvm/pull/14440#discussion_r1153886330 ## src/relax/ir/dataflow_matcher.cc: ## @@ -540,33 +541,48 @@ struct RNode { /** * \brief This method try to match a real node and a pattern node along with its neighb

[GitHub] [tvm] masahi commented on a diff in pull request #14440: [Unity][Graph matching] Clean up undo stack for parent and child nodes properly

2023-03-30 Thread via GitHub
masahi commented on code in PR #14440: URL: https://github.com/apache/tvm/pull/14440#discussion_r1153884915 ## src/relax/ir/dataflow_matcher.cc: ## @@ -540,33 +541,48 @@ struct RNode { /** * \brief This method try to match a real node and a pattern node along with its neighb

[GitHub] [tvm] masahi commented on a diff in pull request #14440: [Unity][Graph matching] Clean up undo stack for parent and child nodes properly

2023-03-30 Thread via GitHub
masahi commented on code in PR #14440: URL: https://github.com/apache/tvm/pull/14440#discussion_r1153876511 ## src/relax/analysis/udchain.cc: ## @@ -65,36 +65,36 @@ class UDChain : public relax::ExprVisitor { std::pair>, runtime::Array> FunctionUseDef( const Function& fn)