[GitHub] [tvm] masahi commented on pull request #14417: [Unity] Remove non-deterministic behavior from graph pattern matching

masahi commented on PR #14417: URL: https://github.com/apache/tvm/pull/14417#issuecomment-1490049917 Just hit an interesting bug in the graph matcher. The following fake QKV projection mod and pattern should not match. Without this PR I get segfault. With this PR, it incorrectly match

[GitHub] [tvm] masahi commented on pull request #14417: [Unity] Remove non-deterministic behavior from graph pattern matching

masahi commented on PR #14417: URL: https://github.com/apache/tvm/pull/14417#issuecomment-1487654668 @ganler Is `start_hint` stuff necessary? I want to remove it, since matching is now deterministic. Some tests depend on the use of `start_hint`. -- This is an automated message from the Ap