[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r540659762 ## File path: python/tvm/topi/cuda/nms.py ## @@ -554,12 +757,7 @@ def non_max_suppression( score_axis = score_index score_shape = (batch_size, nu

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r540658345 ## File path: python/tvm/topi/cuda/sort.py ## @@ -103,9 +103,9 @@ def sort_ir(data, values_out, axis, is_ascend, indices_out=None): nthread_bx = shap

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r540658116 ## File path: python/tvm/topi/cuda/sort.py ## @@ -103,9 +103,9 @@ def sort_ir(data, values_out, axis, is_ascend, indices_out=None): nthread_bx = shap

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r540639712 ## File path: tests/python/relay/test_op_level5.py ## @@ -393,8 +393,6 @@ def verify_nms( intrp2 = relay.create_executor("debug", ctx=ctx, tar

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r539701202 ## File path: python/tvm/topi/cuda/nms.py ## @@ -97,47 +97,44 @@ def get_valid_counts_ir( valid_count = ib.buffer_ptr(valid_count) out = ib.buffe

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r539700714 ## File path: python/tvm/topi/cuda/nms.py ## @@ -97,47 +97,44 @@ def get_valid_counts_ir( valid_count = ib.buffer_ptr(valid_count) out = ib.buffe

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r539700585 ## File path: python/tvm/topi/cuda/nms.py ## @@ -97,47 +97,44 @@ def get_valid_counts_ir( valid_count = ib.buffer_ptr(valid_count) out = ib.buffe

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r539624790 ## File path: python/tvm/topi/cuda/nms.py ## @@ -97,47 +97,44 @@ def get_valid_counts_ir( valid_count = ib.buffer_ptr(valid_count) out = ib.buffe

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r538588187 ## File path: python/tvm/topi/cuda/nms.py ## @@ -519,14 +557,90 @@ def non_max_suppression( coord_start, id_index, s

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r538542467 ## File path: python/tvm/topi/cuda/sort.py ## @@ -201,9 +201,9 @@ def sort_nms_ir(data, valid_count, output, axis, is_ascend): nthread_tx = max_thread

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r538542467 ## File path: python/tvm/topi/cuda/sort.py ## @@ -201,9 +201,9 @@ def sort_nms_ir(data, valid_count, output, axis, is_ascend): nthread_tx = max_thread

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r538539246 ## File path: python/tvm/topi/cuda/nms.py ## @@ -97,47 +97,44 @@ def get_valid_counts_ir( valid_count = ib.buffer_ptr(valid_count) out = ib.buffe

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r538538904 ## File path: python/tvm/topi/cuda/nms.py ## @@ -97,47 +97,44 @@ def get_valid_counts_ir( valid_count = ib.buffer_ptr(valid_count) out = ib.buffe

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r537873092 ## File path: python/tvm/topi/cuda/nms.py ## @@ -54,64 +54,66 @@ def atomic_add(x, y): return tvm.tir.call_intrin(y.dtype, "tir.atomic_add", x, y)

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r537847330 ## File path: python/tvm/topi/cuda/nms.py ## @@ -97,47 +97,44 @@ def get_valid_counts_ir( valid_count = ib.buffer_ptr(valid_count) out = ib.buffe

[GitHub] [tvm] mbrookhart commented on a change in pull request #6839: [ONNX] NMS in ONNX

mbrookhart commented on a change in pull request #6839: URL: https://github.com/apache/tvm/pull/6839#discussion_r537667569 ## File path: python/tvm/topi/cuda/nms.py ## @@ -97,47 +97,44 @@ def get_valid_counts_ir( valid_count = ib.buffer_ptr(valid_count) out = ib.buffe