[GitHub] [tvm] mbrookhart commented on pull request #7883: [ONNX][TOPI][RELAY] Resize refactor

2021-04-21 Thread GitBox
mbrookhart commented on pull request #7883: URL: https://github.com/apache/tvm/pull/7883#issuecomment-824136011 I changed the order of operations on align_corner from out = a / b * x to out = x * a / b. That seems to have caused some rounding errors on GPU, if I revert the change the inter

[GitHub] [tvm] mbrookhart commented on pull request #7883: [ONNX][TOPI][RELAY] Resize refactor

2021-04-21 Thread GitBox
mbrookhart commented on pull request #7883: URL: https://github.com/apache/tvm/pull/7883#issuecomment-824129779 I'm hitting a small and intermittent atol issue with the TF tests on GPU. Before bumping it from 1e-5 to 2e-5, I'm trying to figure out if I actually changed the behavior for the