[GitHub] [tvm] mdw-octoml commented on pull request #7869: Update ICHECK error message with link to documentation page.

2021-04-22 Thread GitBox
mdw-octoml commented on pull request #7869: URL: https://github.com/apache/tvm/pull/7869#issuecomment-824974829 @tqchen @jroesch Looks like this is good to land -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tvm] mdw-octoml commented on pull request #7869: Update ICHECK error message with link to documentation page.

2021-04-21 Thread GitBox
mdw-octoml commented on pull request #7869: URL: https://github.com/apache/tvm/pull/7869#issuecomment-824425907 I think I have resolved the merge issue, this should be good to land once CI passes. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [tvm] mdw-octoml commented on pull request #7869: Update ICHECK error message with link to documentation page.

2021-04-19 Thread GitBox
mdw-octoml commented on pull request #7869: URL: https://github.com/apache/tvm/pull/7869#issuecomment-822951165 I feel like that should be a separate PR. If you can tell me where to make the change, I will, but in general one should avoid mixing unrelated changes in a single PR.

[GitHub] [tvm] mdw-octoml commented on pull request #7869: Update ICHECK error message with link to documentation page.

2021-04-19 Thread GitBox
mdw-octoml commented on pull request #7869: URL: https://github.com/apache/tvm/pull/7869#issuecomment-822723933 I changed it to "What to do when encountering TVM errors" -- WDYT? On Mon, Apr 19, 2021 at 10:26 AM Tianqi Chen ***@***.***> wrote: > Makes sense. Wonders if w

[GitHub] [tvm] mdw-octoml commented on pull request #7869: Update ICHECK error message with link to documentation page.

2021-04-19 Thread GitBox
mdw-octoml commented on pull request #7869: URL: https://github.com/apache/tvm/pull/7869#issuecomment-822570907 Fixed the lint error. The existing error handling doc is for TVM developers, not TVM users. (It is also fairly confusing and includes a lot of details that someone simply u