sergei-grechanik commented on pull request #7943: URL: https://github.com/apache/tvm/pull/7943#issuecomment-829543534
So the problem is that DivNode may be used for both integers and floats, but truncdiv checks that its arguments are actually integers. The change looks correct. I don't think that we need to change the ModNode case, I guess it cannot be used with floats, although I'm not 100% sure about that (but it seems, truncmod doesn't check if the arguments are integers, at least not directly). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
