tmoreau89 commented on pull request #6126:
URL: https://github.com/apache/tvm/pull/6126#issuecomment-823416162
Thank you @zhanghaohit @liangfu @vegaluisjose this PR has been merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
tmoreau89 commented on pull request #6126:
URL: https://github.com/apache/tvm/pull/6126#issuecomment-822671682
Thank you @zhanghaohit I'm very glad we finally have this PR ready to go. I
did one more pass at the PR, and noticed that there is one comment we should
remove, but first I'd like
tmoreau89 commented on pull request #6126:
URL: https://github.com/apache/tvm/pull/6126#issuecomment-822019563
https://github.com/apache/tvm-vta/pull/24 is now merged, we should be good
to update the submodule and CI
--
This is an automated message from the Apache Git Service.
To respond
tmoreau89 commented on pull request #6126:
URL: https://github.com/apache/tvm/pull/6126#issuecomment-820641603
Excellent, thank you for testing the fix @zhanghaohit ! I suggest we proceed
in the following way:
1. Merge the https://github.com/apache/tvm-vta/pull/24 patch so chisel uni
tmoreau89 commented on pull request #6126:
URL: https://github.com/apache/tvm/pull/6126#issuecomment-782559505
You are indeed correct @liangfu the Chisel design doesn't derive parameters
from the hardware_params.h file, so we'll have to reflect the parameterization
in the Chisel design. CC
tmoreau89 commented on pull request #6126:
URL: https://github.com/apache/tvm/pull/6126#issuecomment-758111954
@zhanghaohit can you update this PR to update the VTA submodule to the
latest? Currently other PRs that update the VTA submodule will break unless we
merge this PR. Thanks!
tmoreau89 commented on pull request #6126:
URL: https://github.com/apache/tvm/pull/6126#issuecomment-742921873
https://github.com/apache/tvm-vta/pull/9 is finally merged! @zhanghaohit can
you please update submodule and let's make sure that the unit tests do pass now
that the ISA has chang
