[GitHub] [tvm] tqchen commented on pull request #12140: [LLVM] Create LLVM scope object for use with LLVM libraries

2022-08-03 Thread GitBox
tqchen commented on PR #12140: URL: https://github.com/apache/tvm/pull/12140#issuecomment-1204419044 LLVMInstance sounds good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] tqchen commented on pull request #12140: [LLVM] Create LLVM scope object for use with LLVM libraries

2022-08-03 Thread GitBox
tqchen commented on PR #12140: URL: https://github.com/apache/tvm/pull/12140#issuecomment-1204140133 Thanks @kparzysz-quic , my guess is that we just need naming and documentation clarifications. e.g. the perhaps we can change name of LLVMScope to LLVMContext to capture the fact that it is

[GitHub] [tvm] tqchen commented on pull request #12140: [LLVM] Create LLVM scope object for use with LLVM libraries

2022-08-03 Thread GitBox
tqchen commented on PR #12140: URL: https://github.com/apache/tvm/pull/12140#issuecomment-1204060680 Sorry for delayed reply. Approving as it is a good chunk of improvement. It would be great to discuss naming and documentation a bit. When I see LLVMScope, I was expecting LLVM to tak