[GitHub] [tvm] tqchen commented on pull request #7875: Custom dyld linker for iOS mach-o executable files

2021-05-19 Thread GitBox
tqchen commented on pull request #7875: URL: https://github.com/apache/tvm/pull/7875#issuecomment-844263545 Thanks @apeskov ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [tvm] tqchen commented on pull request #7875: Custom dyld linker for iOS mach-o executable files

2021-05-06 Thread GitBox
tqchen commented on pull request #7875: URL: https://github.com/apache/tvm/pull/7875#issuecomment-833584917 Thanks @apeskov I agree moving the changes into the iOS rpc app. The files we include in the 3rdparty would beed to be apache compatible, because we bundle and release the source co

[GitHub] [tvm] tqchen commented on pull request #7875: Custom dyld linker for iOS mach-o executable files

2021-05-05 Thread GitBox
tqchen commented on pull request #7875: URL: https://github.com/apache/tvm/pull/7875#issuecomment-832848378 Thanks @apeskov . This is an important step. Would be great if we can think about de-couple further to reverse the dependency. (e.g. make the macho depend on libtvm as a plugin).

[GitHub] [tvm] tqchen commented on pull request #7875: Custom dyld linker for iOS mach-o executable files

2021-04-19 Thread GitBox
tqchen commented on pull request #7875: URL: https://github.com/apache/tvm/pull/7875#issuecomment-822532298 After looking at the source code, I think it would be better to isolate the piece of macho-dyld linker as a separate repo while exposing a set of common C APIs that we can depend on,

[GitHub] [tvm] tqchen commented on pull request #7875: Custom dyld linker for iOS mach-o executable files

2021-04-19 Thread GitBox
tqchen commented on pull request #7875: URL: https://github.com/apache/tvm/pull/7875#issuecomment-822520669 Thanks @apeskov , it would be great to know if we can rely on the apple DYLD via submodule or linked library. Additionally, we want to check if the license(Apple license) is compatib