[GitHub] [tvm-rfcs] gromero commented on pull request #88: [RFC] Add Commit Message Guideline

2022-09-02 Thread GitBox
gromero commented on PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#issuecomment-1235612896 @areusch @driazati @tqchen @tkonolige @manupak @Lunderberg @mbaret @junrushao @Hzfengsy @slyubomirsky @ekalda thanks a lot for the reviews and support of this RFC! Tracking issue is

[GitHub] [tvm-rfcs] gromero commented on pull request #88: [RFC] Add Commit Message Guideline

2022-08-17 Thread GitBox
gromero commented on PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#issuecomment-1218386487 OK, I agree @leandron @driazati Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm-rfcs] gromero commented on pull request #88: [RFC] Add Commit Message Guideline

2022-08-16 Thread GitBox
gromero commented on PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#issuecomment-1217357505 > @gromero I think I am getting a little confused at the difference between messages in the commits composing the PR and the final commit in main. To make things clearer, I think it would

[GitHub] [tvm-rfcs] gromero commented on pull request #88: [RFC] Add Commit Message Guideline

2022-08-15 Thread GitBox
gromero commented on PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#issuecomment-1215988221 > Can you also include guidelines for 1. how the PR author can update their commits if they are not up to this standard (rebase?) Let's say a PR has just been created. The idea is

[GitHub] [tvm-rfcs] gromero commented on pull request #88: [RFC] Add Commit Message Guideline

2022-08-15 Thread GitBox
gromero commented on PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#issuecomment-1215261260 @areusch @leandron Could you please help me on how to trigger a [VOTE] thread on this RFC? Cheers. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm-rfcs] gromero commented on pull request #88: [RFC] Add Commit Message Guideline

2022-08-15 Thread GitBox
gromero commented on PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#issuecomment-1215257266 @tqchen @jroesch @driazati @areusch @Mousius @manupak @tkonolige @mbaret @leandron @alanmacd -- This is an automated message from the Apache Git Service. To respond to the message,