[GitHub] [tvm-rfcs] leandron commented on pull request #88: [RFC] Add Commit Message Guideline

2022-08-25 Thread GitBox
leandron commented on PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#issuecomment-1227607913 > @leandron @gromero > Just a final remark : dont we need a tracking issue to track actual landing of the PR that adds pull_request.rst to docs ? We do, I think we can create that

[GitHub] [tvm-rfcs] leandron commented on pull request #88: [RFC] Add Commit Message Guideline

2022-08-23 Thread GitBox
leandron commented on PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#issuecomment-1224165355 @areusch can you have a final look and merge if you're happy, before creating the `[VOTE]` thread you mentioned? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [tvm-rfcs] leandron commented on pull request #88: [RFC] Add Commit Message Guideline

2022-08-22 Thread GitBox
leandron commented on PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#issuecomment-1222334914 I think most comments are addressing implementation details of what it being proposed here. There is not really any opposition to move forward with what is being proposed here.

[GitHub] [tvm-rfcs] leandron commented on pull request #88: [RFC] Add Commit Message Guideline

2022-08-17 Thread GitBox
leandron commented on PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#issuecomment-1217692311 > > I think we should explicitly say that whoever is merging the PR needs to copy the description of the PR into the commit message (unless we have changed GitHub to do this