Re: [PR] [Doc] Fixed Docstring usage example in `tvm.ir.make_node` [tvm]

2024-02-20 Thread via GitHub
tqchen merged PR #16610: URL: https://github.com/apache/tvm/pull/16610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

Re: [PR] [Doc] Fixed Docstring usage example in `tvm.ir.make_node` [tvm]

2024-02-20 Thread via GitHub
felix-ro commented on PR #16610: URL: https://github.com/apache/tvm/pull/16610#issuecomment-1953756108 > LGTM, but is there a reason for the `tvm.runtime.String` addition. the FFI call should automatically handle if I'm not mistaken. I just checked the FFI call, and it is handled ther

[PR] [Doc] Fixed Docstring usage example in `tvm.ir.make_node` [tvm]

2024-02-19 Thread via GitHub
felix-ro opened a new pull request, #16610: URL: https://github.com/apache/tvm/pull/16610 The provided usage example for `tvm.ir.make_node` has become outdated. Creating an IR node of type `IntImm` requires the field `span`. Compare: [`make_node` Unit Test](https://github.com/apache