Lunderberg merged PR #15970:
URL: https://github.com/apache/tvm/pull/15970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Lunderberg commented on PR #15970:
URL: https://github.com/apache/tvm/pull/15970#issuecomment-106256
> I'd love to get this PR in quickly as well as a hotfix, but seems i'm
unable to get around the CI...
I think there's a skip CI flag, though whether it is `[skipci]`,
junrushao commented on PR #15970:
URL: https://github.com/apache/tvm/pull/15970#issuecomment-1777422369
I'd love to get this PR in quickly as well as a hotfix, but seems i'm unable
to get around the CI...
--
This is an automated message from the Apache Git Service.
To respond to the
Lunderberg commented on PR #15970:
URL: https://github.com/apache/tvm/pull/15970#issuecomment-1777207584
Whoops, looks like renaming the branch on github accidentally closed the PR.
Thank you on the MSVC weirdnesses, and I've updated the PR to match the way
all other C API functions
Lunderberg closed pull request #15970: [Hotfix] Mark python-FFI handling with
TVM_DLL
URL: https://github.com/apache/tvm/pull/15970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
junrushao commented on PR #15970:
URL: https://github.com/apache/tvm/pull/15970#issuecomment-1776507511
We will further need to expose those methods in a `.h` file, wrapped with
extern "C", and mark with TVM_DLL :-( MSVC is weird
--
This is an automated message from the Apache Git
tqchen commented on PR #15970:
URL: https://github.com/apache/tvm/pull/15970#issuecomment-1776406719
you want to place declaration in the header like the others and put TVM_DLL
there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Lunderberg opened a new pull request, #15970:
URL: https://github.com/apache/tvm/pull/15970
Bugfix for builds on Windows, which has missing symbol exports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
