Re: [PR] [Relax] Implement R.ensure_aligned and update memory planning for R.view [tvm]

Lunderberg commented on code in PR #17145: URL: https://github.com/apache/tvm/pull/17145#discussion_r1679659483 ## src/relax/transform/static_plan_block_memory.cc: ## @@ -286,8 +286,13 @@ class TokenAllocator1D { std::vector full_pool_; }; -/*! \brief Check if the input op

Re: [PR] [Relax] Implement R.ensure_aligned and update memory planning for R.view [tvm]

vinx13 commented on code in PR #17145: URL: https://github.com/apache/tvm/pull/17145#discussion_r1678444377 ## src/relax/op/memory/view.cc: ## @@ -334,13 +334,12 @@ Expr LegalizeView(const BlockBuilder& bb, const Call& call) { relative_byte_offset = relax::PrimValue::Int64

Re: [PR] [Relax] Implement R.ensure_aligned and update memory planning for R.view [tvm]

tqchen commented on PR #17145: URL: https://github.com/apache/tvm/pull/17145#issuecomment-2223470289 > I like this idea, but I don't think we should move the definition of the legalized form into the LowerRuntimeBuiltin. What if we were to instead add a new attribute, which has the same sig

Re: [PR] [Relax] Implement R.ensure_aligned and update memory planning for R.view [tvm]

Lunderberg commented on PR #17145: URL: https://github.com/apache/tvm/pull/17145#issuecomment-2223289279 > Perhaps one way to make it more clear is to rename LowerVMBuiltin to LowerRuntimeBuiltin, which have clear indication that that is a pass which takes charge of lowering all implementai

Re: [PR] [Relax] Implement R.ensure_aligned and update memory planning for R.view [tvm]

tqchen commented on PR #17145: URL: https://github.com/apache/tvm/pull/17145#issuecomment-2221657695 There are different ways to look at this particular case. For this particular case, given the view was lowered to runtime function, it was primarily focused for the VM itself. One can

Re: [PR] [Relax] Implement R.ensure_aligned and update memory planning for R.view [tvm]

Lunderberg commented on PR #17145: URL: https://github.com/apache/tvm/pull/17145#issuecomment-2221383953 > Based on the current grouping, seems quite a bit of the runtime function dispatchings happens in LowerBuiltin, while legalizeOps primarily focused on lowering to TIR related functions.

Re: [PR] [Relax] Implement R.ensure_aligned and update memory planning for R.view [tvm]

tqchen commented on PR #17145: URL: https://github.com/apache/tvm/pull/17145#issuecomment-2220972695 Based on the current grouping, seems quite a bit of the runtime function dispatchings happens in LowerBuiltin, while legalizeOps primarily focused on lowering to TIR related functions.

Re: [PR] [Relax] Implement R.ensure_aligned and update memory planning for R.view [tvm]

Lunderberg commented on PR #17145: URL: https://github.com/apache/tvm/pull/17145#issuecomment-2220768515 Also, if you're interested, I have a partial implementation in [this dev branch](https://github.com/apache/tvm/compare/main...Lunderberg:temp_relax_implement_ensure_aligned_operator) tha

Re: [PR] [Relax] Implement R.ensure_aligned and update memory planning for R.view [tvm]

Lunderberg commented on code in PR #17145: URL: https://github.com/apache/tvm/pull/17145#discussion_r1672412396 ## python/tvm/relax/op/memory/view.py: ## @@ -92,3 +92,20 @@ def _normalize(expr, relax_cls): relative_byte_offset = _normalize(relative_byte_offset, PrimValue)