Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

lhutton1 commented on PR #16523: URL: https://github.com/apache/tvm/pull/16523#issuecomment-1953777295 Thanks @ekalda @tqchen @Lunderberg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

lhutton1 merged PR #16523: URL: https://github.com/apache/tvm/pull/16523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

ekalda commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1494419765 ## include/tvm/runtime/data_type.h: ## @@ -90,7 +91,10 @@ class DataType { /*! \return number of bytes to store each scalar. */ int bytes() const { return (bits() +

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

ekalda commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1494419477 ## include/tvm/runtime/data_type.h: ## @@ -114,17 +118,28 @@ class DataType { /*! \return whether type is a handle type. */ bool is_handle() const { return code() ==

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

ekalda commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1494419062 ## include/tvm/runtime/data_type.h: ## @@ -114,17 +118,28 @@ class DataType { /*! \return whether type is a handle type. */ bool is_handle() const { return code() ==

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

ekalda commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1494417686 ## src/arith/scalable_expression.cc: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

ekalda commented on PR #16523: URL: https://github.com/apache/tvm/pull/16523#issuecomment-1941936705 Thanks @tqchen, @Lunderberg and @lhutton1 for your feedback, I uploaded a reworked version of the patch. Here's what's changed: * Separation of `vscale` multiplier and fixed length vec

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

tqchen commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1481512533 ## include/tvm/runtime/data_type.h: ## @@ -114,17 +118,28 @@ class DataType { /*! \return whether type is a handle type. */ bool is_handle() const { return code() ==

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

ekalda commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1481340370 ## src/arith/scalable_expression.cc: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

ekalda commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1481333743 ## src/arith/rewrite_simplify.h: ## @@ -221,6 +221,8 @@ class RewriteSimplifier::Impl : public IRMutatorWithAnalyzer { bool CanProveGreaterEqual(const PrimExpr& x, int

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

ekalda commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1481333106 ## src/arith/int_set.cc: ## @@ -466,14 +466,21 @@ class IntervalSetEvaluator : public ExprFunctor { if (stride.Match(op->stride)) { DataType t = op->base.dtyp

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

ekalda commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1481332421 ## include/tvm/runtime/data_type.h: ## @@ -114,17 +118,28 @@ class DataType { /*! \return whether type is a handle type. */ bool is_handle() const { return code() ==

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

tqchen commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1479944776 ## include/tvm/runtime/data_type.h: ## @@ -90,7 +91,10 @@ class DataType { /*! \return number of bytes to store each scalar. */ int bytes() const { return (bits() +

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

tqchen commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1479943939 ## include/tvm/runtime/data_type.h: ## @@ -90,7 +91,10 @@ class DataType { /*! \return number of bytes to store each scalar. */ int bytes() const { return (bits() +

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

tqchen commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1479937161 ## include/tvm/runtime/data_type.h: ## @@ -114,17 +118,28 @@ class DataType { /*! \return whether type is a handle type. */ bool is_handle() const { return code() ==

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

Lunderberg commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1479933863 ## src/arith/scalable_expression.cc: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

tqchen commented on PR #16523: URL: https://github.com/apache/tvm/pull/16523#issuecomment-1929872017 if it is not high effort, consider add https://github.com/apache/tvm/blob/main/python/tvm/ir/json_compact.py so previously serialized node can be loaded -- This is an automated message f

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

Lunderberg commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1479921289 ## src/arith/rewrite_simplify.h: ## @@ -221,6 +221,8 @@ class RewriteSimplifier::Impl : public IRMutatorWithAnalyzer { bool CanProveGreaterEqual(const PrimExpr& x,

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

Lunderberg commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1479902583 ## src/arith/pattern_match.h: ## @@ -628,10 +628,11 @@ inline PRampExpr ramp(const Pattern& base, } template -inline PRampExpr, PConst> ramp(const Pattern& base

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

lhutton1 commented on code in PR #16523: URL: https://github.com/apache/tvm/pull/16523#discussion_r1478630929 ## src/arith/scalable_expression.cc: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

ekalda commented on PR #16523: URL: https://github.com/apache/tvm/pull/16523#issuecomment-1929039209 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

ekalda commented on PR #16523: URL: https://github.com/apache/tvm/pull/16523#issuecomment-1927394597 cc @neildhickey @lhutton1 @tqchen @cbalint13 @Lunderberg @Anndrey24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] [SVE] Change the dtype of Ramp and Broadcast lanes to PrimExpr [tvm]

ekalda opened a new pull request, #16523: URL: https://github.com/apache/tvm/pull/16523 This change will allow us to express scalable vectors through Ramp and Broadcast nodes, e.g. ``` vec = tvm.tir.expr.Ramp(0, 1, 4 * tvm.tir.vscale()) ``` We will use negative values for `runtim