Re: [PR] [TVMScript] Produce empty DictAttrs when R.func_attrs is absent [tvm]

2024-04-05 Thread via GitHub
Lunderberg merged PR #16844: URL: https://github.com/apache/tvm/pull/16844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apach

Re: [PR] [TVMScript] Produce empty DictAttrs when R.func_attrs is absent [tvm]

2024-04-03 Thread via GitHub
Lunderberg commented on PR #16844: URL: https://github.com/apache/tvm/pull/16844#issuecomment-2036062916 Overall, to remove a repeated source of bugs. Since most functions are publicly exposed, they'll have at least the `"global_symbol"` attribute. Frequently, utilities would be written t

Re: [PR] [TVMScript] Produce empty DictAttrs when R.func_attrs is absent [tvm]

2024-04-03 Thread via GitHub
slyubomirsky commented on PR #16844: URL: https://github.com/apache/tvm/pull/16844#issuecomment-2035582213 What is the specific reason to have this change? It might be a good invariant to have, just wondering if there was a specific motivation for it. -- This is an automated message from

[PR] [TVMScript] Produce empty DictAttrs when R.func_attrs is absent [tvm]

2024-04-03 Thread via GitHub
Lunderberg opened a new pull request, #16844: URL: https://github.com/apache/tvm/pull/16844 A follow-up to https://github.com/apache/tvm/pull/16745. For Relax functions produced in TVMScript, when `R.func_attrs` was not present, the default was set to `None` instead of an empty dictionary.