Re: [PR] [Transform][Bugfix] Handle non-composite lambda functions in FuseOps [tvm]

2024-02-20 Thread via GitHub
Lunderberg commented on code in PR #16598: URL: https://github.com/apache/tvm/pull/16598#discussion_r1496878192 ## src/relax/transform/fuse_ops.cc: ## @@ -1238,10 +1238,14 @@ class CompositeFunctionAnnotator : public ExprMutator { Expr VisitExpr_(const FunctionNode* func_no

Re: [PR] [Transform][Bugfix] Handle non-composite lambda functions in FuseOps [tvm]

2024-02-20 Thread via GitHub
vinx13 commented on code in PR #16598: URL: https://github.com/apache/tvm/pull/16598#discussion_r1496741848 ## src/relax/transform/fuse_ops.cc: ## @@ -1238,10 +1238,14 @@ class CompositeFunctionAnnotator : public ExprMutator { Expr VisitExpr_(const FunctionNode* func_node)

Re: [PR] [Transform][Bugfix] Handle non-composite lambda functions in FuseOps [tvm]

2024-02-20 Thread via GitHub
Lunderberg commented on code in PR #16598: URL: https://github.com/apache/tvm/pull/16598#discussion_r1496740578 ## src/relax/transform/fuse_ops.cc: ## @@ -1238,10 +1238,14 @@ class CompositeFunctionAnnotator : public ExprMutator { Expr VisitExpr_(const FunctionNode* func_no

Re: [PR] [Transform][Bugfix] Handle non-composite lambda functions in FuseOps [tvm]

2024-02-20 Thread via GitHub
vinx13 merged PR #16598: URL: https://github.com/apache/tvm/pull/16598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

Re: [PR] [Transform][Bugfix] Handle non-composite lambda functions in FuseOps [tvm]

2024-02-20 Thread via GitHub
Lunderberg commented on code in PR #16598: URL: https://github.com/apache/tvm/pull/16598#discussion_r1496737460 ## src/relax/transform/fuse_ops.cc: ## @@ -1238,10 +1238,14 @@ class CompositeFunctionAnnotator : public ExprMutator { Expr VisitExpr_(const FunctionNode* func_no

Re: [PR] [Transform][Bugfix] Handle non-composite lambda functions in FuseOps [tvm]

2024-02-20 Thread via GitHub
vinx13 commented on code in PR #16598: URL: https://github.com/apache/tvm/pull/16598#discussion_r1496719908 ## src/relax/transform/fuse_ops.cc: ## @@ -1238,10 +1238,14 @@ class CompositeFunctionAnnotator : public ExprMutator { Expr VisitExpr_(const FunctionNode* func_node)

[PR] [Transform][Bugfix] Handle non-composite lambda functions in FuseOps [tvm]

2024-02-16 Thread via GitHub
Lunderberg opened a new pull request, #16598: URL: https://github.com/apache/tvm/pull/16598 Prior to this commit, calling `FuseOpsByPattern` with `annotate_codegen=True` would cause an error when encountering a lambda function. This was caused by the `CompositeFunctionAnnotator` asserting