Re: [PR] [Unity][Op] Allow the argument to `call_tir` to be a var bound to a tuple, not a tuple literal [tvm]

2023-10-25 Thread via GitHub
slyubomirsky closed pull request #15971: [Unity][Op] Allow the argument to `call_tir` to be a var bound to a tuple, not a tuple literal URL: https://github.com/apache/tvm/pull/15971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [Unity][Op] Allow the argument to `call_tir` to be a var bound to a tuple, not a tuple literal [tvm]

2023-10-25 Thread via GitHub
slyubomirsky commented on PR #15971: URL: https://github.com/apache/tvm/pull/15971#issuecomment-1779980410 Didn't see it, yep, they're duplicates. There is one case that the other PR misses so hopefully that can be updated. -- This is an automated message from the Apache Git Service. To r

Re: [PR] [Unity][Op] Allow the argument to `call_tir` to be a var bound to a tuple, not a tuple literal [tvm]

2023-10-25 Thread via GitHub
quic-sanirudh commented on PR #15971: URL: https://github.com/apache/tvm/pull/15971#issuecomment-1779451578 > This may be a duplicate of #15916, which also resolves the analogous problem for `FuseOps`, `RewriteDataflowReshape`, and `FoldConstant`. Oh nice, this is great, thanks for th

Re: [PR] [Unity][Op] Allow the argument to `call_tir` to be a var bound to a tuple, not a tuple literal [tvm]

2023-10-25 Thread via GitHub
Lunderberg commented on PR #15971: URL: https://github.com/apache/tvm/pull/15971#issuecomment-1779402991 This may be a duplicate of https://github.com/apache/tvm/pull/15916, which also resolves the analogous problem for `FuseOps`, `RewriteDataflowReshape`, and `FoldConstant`. -- This is

[PR] [Unity][Op] Allow the argument to `call_tir` to be a var bound to a tuple, not a tuple literal [tvm]

2023-10-23 Thread via GitHub
slyubomirsky opened a new pull request, #15971: URL: https://github.com/apache/tvm/pull/15971 In response to the issue in common subexpression elimination noted in this [forum post](https://discuss.tvm.apache.org/t/validity-of-common-subexpression-elimination-pass-that-simplifies-call-tir-a