Re: [PR] [Unity][Transform] Improved canonicalization of non-dataflow Var [tvm]

2023-10-25 Thread via GitHub
Lunderberg merged PR #15941: URL: https://github.com/apache/tvm/pull/15941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Unity][Transform] Improved canonicalization of non-dataflow Var [tvm]

2023-10-25 Thread via GitHub
Lunderberg commented on PR #15941: URL: https://github.com/apache/tvm/pull/15941#issuecomment-1779377445 No problem! I'm going to merge this in, as it resolves a few test failures in unity head that resulted from a conflict between

Re: [PR] [Unity][Transform] Improved canonicalization of non-dataflow Var [tvm]

2023-10-24 Thread via GitHub
slyubomirsky commented on code in PR #15941: URL: https://github.com/apache/tvm/pull/15941#discussion_r1370981296 ## src/relax/transform/canonicalize_bindings.cc: ## @@ -33,68 +33,198 @@ namespace tvm { namespace relax { -class BindingCanonicalizer : public ExprMutator {

Re: [PR] [Unity][Transform] Improved canonicalization of non-dataflow Var [tvm]

2023-10-24 Thread via GitHub
slyubomirsky commented on code in PR #15941: URL: https://github.com/apache/tvm/pull/15941#discussion_r1370981017 ## src/relax/transform/canonicalize_bindings.cc: ## @@ -33,68 +33,198 @@ namespace tvm { namespace relax { -class BindingCanonicalizer : public ExprMutator {

Re: [PR] [Unity][Transform] Improved canonicalization of non-dataflow Var [tvm]

2023-10-24 Thread via GitHub
Lunderberg commented on code in PR #15941: URL: https://github.com/apache/tvm/pull/15941#discussion_r1370961026 ## src/relax/transform/canonicalize_bindings.cc: ## @@ -33,68 +33,198 @@ namespace tvm { namespace relax { -class BindingCanonicalizer : public ExprMutator {

Re: [PR] [Unity][Transform] Improved canonicalization of non-dataflow Var [tvm]

2023-10-24 Thread via GitHub
Lunderberg commented on code in PR #15941: URL: https://github.com/apache/tvm/pull/15941#discussion_r1370955234 ## src/relax/transform/canonicalize_bindings.cc: ## @@ -33,68 +33,198 @@ namespace tvm { namespace relax { -class BindingCanonicalizer : public ExprMutator {

Re: [PR] [Unity][Transform] Improved canonicalization of non-dataflow Var [tvm]

2023-10-24 Thread via GitHub
Lunderberg commented on code in PR #15941: URL: https://github.com/apache/tvm/pull/15941#discussion_r1370951291 ## src/relax/transform/canonicalize_bindings.cc: ## @@ -33,68 +33,198 @@ namespace tvm { namespace relax { -class BindingCanonicalizer : public ExprMutator {

Re: [PR] [Unity][Transform] Improved canonicalization of non-dataflow Var [tvm]

2023-10-24 Thread via GitHub
Lunderberg commented on code in PR #15941: URL: https://github.com/apache/tvm/pull/15941#discussion_r1370950270 ## src/relax/transform/canonicalize_bindings.cc: ## @@ -33,68 +33,198 @@ namespace tvm { namespace relax { -class BindingCanonicalizer : public ExprMutator {

Re: [PR] [Unity][Transform] Improved canonicalization of non-dataflow Var [tvm]

2023-10-24 Thread via GitHub
slyubomirsky commented on code in PR #15941: URL: https://github.com/apache/tvm/pull/15941#discussion_r1370925361 ## src/relax/transform/canonicalize_bindings.cc: ## @@ -33,68 +33,198 @@ namespace tvm { namespace relax { -class BindingCanonicalizer : public ExprMutator {

Re: [PR] [Unity][Transform] Improved canonicalization of non-dataflow Var [tvm]

2023-10-24 Thread via GitHub
slyubomirsky commented on code in PR #15941: URL: https://github.com/apache/tvm/pull/15941#discussion_r1370915636 ## src/relax/transform/canonicalize_bindings.cc: ## @@ -33,68 +33,198 @@ namespace tvm { namespace relax { -class BindingCanonicalizer : public ExprMutator {

Re: [PR] [Unity][Transform] Improved canonicalization of non-dataflow Var [tvm]

2023-10-24 Thread via GitHub
Lunderberg commented on PR #15941: URL: https://github.com/apache/tvm/pull/15941#issuecomment-1777901385 Rebased onto unity head and resolved conflicts with the https://github.com/apache/tvm/pull/15791. -- This is an automated message from the Apache Git Service. To respond to the