Re: [PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

sunggg merged PR #17149: URL: https://github.com/apache/tvm/pull/17149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

Re: [PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

Lunderberg commented on PR #17149: URL: https://github.com/apache/tvm/pull/17149#issuecomment-2231547105 > I think it is absolutely okay to have some rough edges that we cannot support yet, but I hope we clearly document in the code so that people won't get confused. Agreed. Any uns

Re: [PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

Lunderberg commented on code in PR #17149: URL: https://github.com/apache/tvm/pull/17149#discussion_r1679862143 ## python/tvm/relax/dpl/rewrite.py: ## @@ -15,16 +15,154 @@ # specific language governing permissions and limitations # under the License. """APIs for pattern-based

Re: [PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

Lunderberg commented on code in PR #17149: URL: https://github.com/apache/tvm/pull/17149#discussion_r1679751777 ## python/tvm/relax/dpl/rewrite.py: ## @@ -15,16 +15,154 @@ # specific language governing permissions and limitations # under the License. """APIs for pattern-based

Re: [PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

sunggg commented on PR #17149: URL: https://github.com/apache/tvm/pull/17149#issuecomment-2231289046 Thanks, @Lunderberg for the clarification! I think it is absolutely okay to have some rough edges that we cannot support yet, but I hope we clearly document in the code so that people won't

Re: [PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

sunggg commented on code in PR #17149: URL: https://github.com/apache/tvm/pull/17149#discussion_r1679671608 ## python/tvm/relax/dpl/rewrite.py: ## @@ -15,16 +15,154 @@ # specific language governing permissions and limitations # under the License. """APIs for pattern-based rew

Re: [PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

Lunderberg commented on PR #17149: URL: https://github.com/apache/tvm/pull/17149#issuecomment-2228897543 > My main question for you is if this PR is aiming the full support for the existing pattern language. It is okay if there are some rough edges that we don't currently support, but I wou

Re: [PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

Lunderberg commented on code in PR #17149: URL: https://github.com/apache/tvm/pull/17149#discussion_r1678069263 ## tests/python/relax/test_dataflow_rewriter.py: ## @@ -0,0 +1,1370 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agr

Re: [PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

Lunderberg commented on code in PR #17149: URL: https://github.com/apache/tvm/pull/17149#discussion_r1677910957 ## tests/python/relax/test_dataflow_rewriter.py: ## @@ -0,0 +1,1370 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agr

Re: [PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

Lunderberg commented on code in PR #17149: URL: https://github.com/apache/tvm/pull/17149#discussion_r1677904909 ## python/tvm/relax/dpl/rewrite.py: ## @@ -15,16 +15,154 @@ # specific language governing permissions and limitations # under the License. """APIs for pattern-based

Re: [PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

Lunderberg commented on code in PR #17149: URL: https://github.com/apache/tvm/pull/17149#discussion_r1677894422 ## python/tvm/relax/dpl/rewrite.py: ## @@ -15,16 +15,154 @@ # specific language governing permissions and limitations # under the License. """APIs for pattern-based

Re: [PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

Lunderberg commented on code in PR #17149: URL: https://github.com/apache/tvm/pull/17149#discussion_r1677870641 ## include/tvm/relax/block_builder.h: ## @@ -133,16 +133,47 @@ class BlockBuilderNode : public Object { * \brief Begin a new scope, with optional parameters that

Re: [PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

sunggg commented on code in PR #17149: URL: https://github.com/apache/tvm/pull/17149#discussion_r1676465585 ## include/tvm/relax/block_builder.h: ## @@ -133,16 +133,47 @@ class BlockBuilderNode : public Object { * \brief Begin a new scope, with optional parameters that *

Re: [PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

Lunderberg commented on PR #17149: URL: https://github.com/apache/tvm/pull/17149#issuecomment-2221263059 @sunggg @csullivan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [Relax] Implement Rewriter class for pattern-rewrite [tvm]

Lunderberg opened a new pull request, #17149: URL: https://github.com/apache/tvm/pull/17149 Prior to this commit, the pattern to be matched and the rewrite to be performed were provided as separate arguments to `rewrite_call`. This commit introduces a new class `ExprRewriter`, which contai