[GitHub] incubator-weex issue #860: [WEEX-112][iOS] make weex playground app adapt to...

2017-11-21 Thread gurisxie
Github user gurisxie commented on the issue: https://github.com/apache/incubator-weex/pull/860 This PR has been merged and will close soon, thanks ^_^ ---

[GitHub] incubator-weex pull request #860: [WEEX-112][iOS] make weex playground app a...

2017-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex/pull/860 ---

incubator-weex git commit: [WEEX-112][iOS] make weex playground app adapt to iPhone X

2017-11-21 Thread gurisxie
Repository: incubator-weex Updated Branches: refs/heads/master 805f8a832 -> 850f6f47e [WEEX-112][iOS] make weex playground app adapt to iPhone X according to https://developer.apple.com/ios/human-interface-guidelines/icons-and-images/launch-screen/ , we must add a 1125px X 2436px launch im

incubator-weex git commit: close #896

2017-11-21 Thread gurisxie
Repository: incubator-weex Updated Branches: refs/heads/master 4e006d88b -> 805f8a832 close #896 Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/805f8a83 Tree: http://git-wip-us.apache.org/repos/asf/incub

[GitHub] incubator-weex pull request #896: [WEEX-131][ios]URL property in error event...

2017-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex/pull/896 ---

incubator-weex git commit: * [test] bug fix , compatibility of maraca can't find element

2017-11-21 Thread gurisxie
Repository: incubator-weex Updated Branches: refs/heads/master 5f3482315 -> 4e006d88b * [test] bug fix , compatibility of maraca can't find element Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/4e006d88

incubator-weex git commit: [WEEX-131][ios]URL property in error event of web component may not be the real URL, fix it.

2017-11-21 Thread gurisxie
Repository: incubator-weex Updated Branches: refs/heads/master ee8094e7f -> 5f3482315 [WEEX-131][ios]URL property in error event of web component may not be the real URL, fix it. In error callback, webview.request may return the previous loaded web page URL, use error.userInfo to get the rea

[GitHub] incubator-weex pull request #822: Remove maven central repository, use only ...

2017-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex/pull/822 ---

incubator-weex git commit: close #822

2017-11-21 Thread gurisxie
Repository: incubator-weex Updated Branches: refs/heads/master 446f5db41 -> ee8094e7f close #822 Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/ee8094e7 Tree: http://git-wip-us.apache.org/repos/asf/incub

[2/2] incubator-weex git commit: Remove maven central repository, use only jcenter

2017-11-21 Thread gurisxie
Remove maven central repository, use only jcenter jcenter is a super set on top of maven central, so having both of those repositories is redundant, and the preferred one should be jcenter. Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo Commit: http://git-wip-us.apache.org/r

[1/2] incubator-weex git commit: Add mavenLocal before jcenter repository

2017-11-21 Thread gurisxie
Repository: incubator-weex Updated Branches: refs/heads/master 1175064cb -> 446f5db41 Add mavenLocal before jcenter repository Ensure trying to resolve dependencies from local maven cache first, before resolving from remove jcenter repository. This is due to a comment in the pull request. P

[GitHub] incubator-weex issue #897: [WEEX-136][iOS] fix 1pixel when UICollectionView ...

2017-11-21 Thread weex-bot
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/897 Warnings :warning: No Changelog changes! :warning:

[GitHub] incubator-weex pull request #897: [WEEX-136][iOS] fix 1pixel when UICollecti...

2017-11-21 Thread acton393
GitHub user acton393 opened a pull request: https://github.com/apache/incubator-weex/pull/897 [WEEX-136][iOS] fix 1pixel when UICollectionView scroll end this case may reproduce problem https://alibaba.github.io/rax/playground/a42d134c-7465-4e20-96c0-fe935cac0170 Bug:13

[GitHub] incubator-weex issue #896: [WEEX-131][ios]URL property in error event of web...

2017-11-21 Thread weex-bot
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/896 Warnings :warning: No Changelog changes! :warning:

[GitHub] incubator-weex pull request #896: [WEEX-131][ios]URL property in error event...

2017-11-21 Thread CYJB
GitHub user CYJB opened a pull request: https://github.com/apache/incubator-weex/pull/896 [WEEX-131][ios]URL property in error event of web component may not be the real URL, fix it. [WEEX-131][ios]URL property in error event of web component may not be the real URL, fix it.

[GitHub] incubator-weex pull request #848: [WEEX-100][iOS] Support customize button t...

2017-11-21 Thread CYJB
Github user CYJB closed the pull request at: https://github.com/apache/incubator-weex/pull/848 ---

[GitHub] incubator-weex pull request #895: [WEEX-131][ios]Fix url property in error e...

2017-11-21 Thread CYJB
Github user CYJB closed the pull request at: https://github.com/apache/incubator-weex/pull/895 ---

[GitHub] incubator-weex issue #895: [WEEX-131][ios]Fix url property in error event of...

2017-11-21 Thread weex-bot
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/895 Warnings :warning: No Changelog changes! :warning:

[GitHub] incubator-weex pull request #895: [WEEX-131][ios]Fix url property in error e...

2017-11-21 Thread CYJB
GitHub user CYJB opened a pull request: https://github.com/apache/incubator-weex/pull/895 [WEEX-131][ios]Fix url property in error event of web component may not be the real URL. [WEEX-131][ios]Fix url property in error event of web component may not be the real URL. In er

[GitHub] incubator-weex pull request #885: [WEEX-131][test]Fix test failed of web com...

2017-11-21 Thread CYJB
Github user CYJB closed the pull request at: https://github.com/apache/incubator-weex/pull/885 ---

[GitHub] incubator-weex pull request #822: Remove maven central repository, use only ...

2017-11-21 Thread misakuo
Github user misakuo commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/822#discussion_r152212531 --- Diff: android/build.gradle --- @@ -1,7 +1,6 @@ buildscript { repositories { -mavenCentral() --- End diff --

[GitHub] incubator-weex issue #822: Remove maven central repository, use only jcenter

2017-11-21 Thread yinonavraham
Github user yinonavraham commented on the issue: https://github.com/apache/incubator-weex/pull/822 Ah, sure, that's ok, sorry for the misunderstanding. I think it is implicit, but it's ok to have it anyway. ---

[GitHub] incubator-weex issue #822: Remove maven central repository, use only jcenter

2017-11-21 Thread misakuo
Github user misakuo commented on the issue: https://github.com/apache/incubator-weex/pull/822 I mean ```groovy repositories { mavenLocal() jcenter() } ``` First find in the local maven cache, if not found, find in jcenter ---

[GitHub] incubator-weex issue #822: Remove maven central repository, use only jcenter

2017-11-21 Thread yinonavraham
Github user yinonavraham commented on the issue: https://github.com/apache/incubator-weex/pull/822 Certainly not. `mavenLocal` is your local maven cache (i.e. the `.m2` directory). Doing so will remove any central maven repository. You should at least have either `jcenter` or `mavenCe

[GitHub] incubator-weex issue #822: Remove maven central repository, use only jcenter

2017-11-21 Thread misakuo
Github user misakuo commented on the issue: https://github.com/apache/incubator-weex/pull/822 Thanks for your contribution. we can remove the `mavenCentral` from repositories, but I think to replace it with `mavenLocal` will be better? ---