[GitHub] incubator-weex pull request #1047: [WEEX-233][iOS] More enhanced about ...

2018-03-07 Thread tw93
GitHub user tw93 reopened a pull request: https://github.com/apache/incubator-weex/pull/1047 [WEEX-233][iOS] More enhanced about component First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank y

[GitHub] incubator-weex pull request #1047: [WEEX-233][iOS] More enhanced about ...

2018-03-07 Thread tw93
Github user tw93 closed the pull request at: https://github.com/apache/incubator-weex/pull/1047 ---

[GitHub] incubator-weex pull request #1048: fix input bug

2018-03-07 Thread marekchen
Github user marekchen closed the pull request at: https://github.com/apache/incubator-weex/pull/1048 ---

[GitHub] incubator-weex issue #1048: [android]fix input bug

2018-03-07 Thread marekchen
Github user marekchen commented on the issue: https://github.com/apache/incubator-weex/pull/1048 can't reopen this pr ---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

2018-03-07 Thread marekchen
GitHub user marekchen opened a pull request: https://github.com/apache/incubator-weex/pull/1053 [android]fix input bug 英文不好就用中文描述了: 1.当在created中设置input的value值为“1”,然后删 除“1”,这时不会触发input事件 2.当输入“

[GitHub] incubator-weex issue #1053: [android]fix input bug

2018-03-07 Thread weex-bot
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/1053 Warnings :warning: No Changelog changes!

[GitHub] incubator-weex pull request #1053: [android]fix input bug

2018-03-07 Thread marekchen
Github user marekchen closed the pull request at: https://github.com/apache/incubator-weex/pull/1053 ---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

2018-03-07 Thread marekchen
GitHub user marekchen reopened a pull request: https://github.com/apache/incubator-weex/pull/1053 [android]fix input bug 英文不好就用中文描述了: 1.当在created中设置input的value值为“1”,然后删 除“1”,这时不会触发input事件 2.当输入â

[GitHub] incubator-weex pull request #1047: [WEEX-233][iOS] More enhanced about ...

2018-03-07 Thread acton393
Github user acton393 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/1047#discussion_r172825375 --- Diff: ios/sdk/WeexSDK/Sources/Module/WXWebViewModule.m --- @@ -27,6 +27,7 @@ @implementation WXWebViewModule @synthesize weexInstance;

[GitHub] incubator-weex pull request #1053: [android]fix input bug

2018-03-07 Thread marekchen
Github user marekchen closed the pull request at: https://github.com/apache/incubator-weex/pull/1053 ---

[GitHub] incubator-weex pull request #1053: [android]fix input bug

2018-03-07 Thread marekchen
GitHub user marekchen reopened a pull request: https://github.com/apache/incubator-weex/pull/1053 [android]fix input bug 英文不好就用中文描述了: 1.当在created中设置input的value值为“1”,然后删 除“1”,这时不会触发input事件 2.当输入â

[GitHub] incubator-weex pull request #1047: [WEEX-233][iOS] More enhanced about ...

2018-03-07 Thread acton393
Github user acton393 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/1047#discussion_r172826404 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m --- @@ -69,6 +71,11 @@ - (instancetype)initWithRef:(NSString *)ref type:(NSString *)ty

[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.

2018-03-07 Thread acton393
Github user acton393 commented on the issue: https://github.com/apache/incubator-weex/pull/1051 @xuyouyang I got it and find the w3c rules about it : https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video thanks, we can make it more standard by add more attributes an

[GitHub] incubator-weex pull request #1051: + [iOS] add WXVideoComponent "poster" att...

2018-03-07 Thread acton393
Github user acton393 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/1051#discussion_r172831893 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXVideoComponent.m --- @@ -85,6 +89,13 @@ - (id)init } [self add

[GitHub] incubator-weex pull request #1047: [WEEX-233][iOS] More enhanced about ...

2018-03-07 Thread tw93
Github user tw93 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/1047#discussion_r172833325 --- Diff: ios/sdk/WeexSDK/Sources/Module/WXWebViewModule.m --- @@ -27,6 +27,7 @@ @implementation WXWebViewModule @synthesize weexInstance; ---

[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.

2018-03-07 Thread acton393
Github user acton393 commented on the issue: https://github.com/apache/incubator-weex/pull/1051 @xuyouyang as the [development process](http://weex.apache.org/development-process.html) shows, we need create a jira issue in apache, and format your pull request title and commit log.

[GitHub] incubator-weex pull request #1047: [WEEX-233][iOS] More enhanced about ...

2018-03-07 Thread acton393
Github user acton393 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/1047#discussion_r172835622 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m --- @@ -104,6 +142,10 @@ - (void)updateAttributes:(NSDictionary *)attributes i

[GitHub] incubator-weex pull request #1047: [WEEX-233][iOS] More enhanced about ...

2018-03-07 Thread tw93
Github user tw93 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/1047#discussion_r172837062 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m --- @@ -104,6 +142,10 @@ - (void)updateAttributes:(NSDictionary *)attributes if (a

[GitHub] incubator-weex pull request #939: fix stream res.ok is undefined when reques...

2018-03-07 Thread marekchen
Github user marekchen closed the pull request at: https://github.com/apache/incubator-weex/pull/939 ---

[GitHub] incubator-weex pull request #1054: [android]fix stream res.ok is undefined w...

2018-03-07 Thread marekchen
GitHub user marekchen opened a pull request: https://github.com/apache/incubator-weex/pull/1054 [android]fix stream res.ok is undefined when request has exception CheckList: **if** *isBugFix* **:** * [x] Make sure that you add at least one unit test for the bug wh

[GitHub] incubator-weex issue #1054: [android]fix stream res.ok is undefined when req...

2018-03-07 Thread weex-bot
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/1054 Messages :book: has no jsfm file changed. :book:

[GitHub] incubator-weex pull request #1054: [android]fix stream res.ok is undefined w...

2018-03-07 Thread marekchen
Github user marekchen closed the pull request at: https://github.com/apache/incubator-weex/pull/1054 ---

[GitHub] incubator-weex pull request #1054: [android]fix stream res.ok is undefined w...

2018-03-07 Thread marekchen
GitHub user marekchen reopened a pull request: https://github.com/apache/incubator-weex/pull/1054 [android]fix stream res.ok is undefined when request has exception CheckList: **if** *isBugFix* **:** * [x] Make sure that you add at least one unit test for the bug

[GitHub] incubator-weex pull request #1051: + [iOS] add WXVideoComponent "poster" att...

2018-03-07 Thread xuyouyang
Github user xuyouyang commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/1051#discussion_r173046770 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXVideoComponent.m --- @@ -85,6 +89,13 @@ - (id)init } [self ad

[GitHub] incubator-weex issue #1051: + [iOS] add WXVideoComponent "poster" attribute.

2018-03-07 Thread xuyouyang
Github user xuyouyang commented on the issue: https://github.com/apache/incubator-weex/pull/1051 OK. Thank you very much! @acton393 ---

[GitHub] incubator-weex pull request #1055: [android] support resize Image in FrescoI...

2018-03-07 Thread xiaoqi951109
GitHub user xiaoqi951109 opened a pull request: https://github.com/apache/incubator-weex/pull/1055 [android] support resize Image in FrescoImageAdapter the default ImageAdapter Supported By Picasso, so a ImgUri with Base64 is not supported ,but resize in Image is not useful in Fresc

[GitHub] incubator-weex issue #1055: [android] support resize Image in FrescoImageAda...

2018-03-07 Thread weex-bot
Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/1055 Messages :book: has no jsfm file changed. :book:

[GitHub] incubator-weex pull request #1049: [WEEX-230][android] Weex Input Value Filt...

2018-03-07 Thread gubaojian
GitHub user gubaojian reopened a pull request: https://github.com/apache/incubator-weex/pull/1049 [WEEX-230][android] Weex Input Value Filter By Diff Update [WEEX-230][android] Weex Input Value Filter By Diff Update http://rax.alibaba-inc.com/playground/08c38f41-49a9-44

[GitHub] incubator-weex pull request #1049: [WEEX-230][android] Weex Input Value Filt...

2018-03-07 Thread gubaojian
Github user gubaojian closed the pull request at: https://github.com/apache/incubator-weex/pull/1049 ---

[GitHub] incubator-weex pull request #1049: [WEEX-230][android] Weex Input Value Filt...

2018-03-07 Thread gubaojian
GitHub user gubaojian reopened a pull request: https://github.com/apache/incubator-weex/pull/1049 [WEEX-230][android] Weex Input Value Filter By Diff Update [WEEX-230][android] Weex Input Value Filter By Diff Update http://rax.alibaba-inc.com/playground/08c38f41-49a9-44

[GitHub] incubator-weex pull request #1049: [WEEX-230][android] Weex Input Value Filt...

2018-03-07 Thread gubaojian
Github user gubaojian closed the pull request at: https://github.com/apache/incubator-weex/pull/1049 ---

[1/3] incubator-weex-site git commit: add application

2018-03-07 Thread hanks
Repository: incubator-weex-site Updated Branches: refs/heads/master 89dc99e08 -> c941b0d76 add application application use weex Project: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/commit/ebbef64c Tree: ht

[3/3] incubator-weex-site git commit: add application (#89)

2018-03-07 Thread hanks
add application (#89) Project: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/commit/c941b0d7 Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/tree/c941b0d7 Diff: http://git-wip-us.apache.org/repo

[2/3] incubator-weex-site git commit: Update users.yml

2018-03-07 Thread hanks
Update users.yml use shorter name "飞呀" Project: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/commit/4e95a78e Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex-site/tree/4e95a78e Diff: http://git-w

[GitHub] incubator-weex issue #1051: [WEEX-241][iOS] add WXVideoComponent "poster" at...

2018-03-07 Thread acton393
Github user acton393 commented on the issue: https://github.com/apache/incubator-weex/pull/1051 @xuyouyang It look good to me and it will be accepted, thank you. It would be better if Android player can support poster attributes. ---

incubator-weex git commit: * [iOS] fix multithread crash about mutable array in scroller component

2018-03-07 Thread acton393
Repository: incubator-weex Updated Branches: refs/heads/master 7c5ef1c68 -> 9c9ae8846 * [iOS] fix multithread crash about mutable array in scroller component Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commi