[GitHub] incubator-weex pull request #1090: [WEEX-267][ios]monitor the frequency of m...

2018-03-28 Thread CYJB
Github user CYJB commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/1090#discussion_r177723438 --- Diff: ios/sdk/WeexSDK/Sources/Protocol/WXAppMonitorProtocol.h --- @@ -54,4 +54,8 @@ - (void)commitAppMonitorAlarm:(NSString *)pageName

[GitHub] incubator-weex pull request #1090: [WEEX-267][ios]monitor the frequency of m...

2018-03-28 Thread CYJB
GitHub user CYJB opened a pull request: https://github.com/apache/incubator-weex/pull/1090 [WEEX-267][ios]monitor the frequency of module invoke Add new optional method for module invoke monitor, do not use alarm anymore. You can merge this pull request into a Git repository by

[GitHub] incubator-weex pull request #903: [WEEX-139][ios]Provide system language inf...

2017-11-22 Thread CYJB
GitHub user CYJB opened a pull request: https://github.com/apache/incubator-weex/pull/903 [WEEX-139][ios]Provide system language infomation Provide locale module, contains information about system language. Example: [http://dotwe.org/vue/fc5e91d6f1a809bab2f073af53f4dd94] You

[GitHub] incubator-weex pull request #902: [WEEX-139][ios]Provide system language inf...

2017-11-22 Thread CYJB
Github user CYJB closed the pull request at: https://github.com/apache/incubator-weex/pull/902 ---

[GitHub] incubator-weex pull request #902: [WEEX-139][ios]Provide system language inf...

2017-11-22 Thread CYJB
GitHub user CYJB opened a pull request: https://github.com/apache/incubator-weex/pull/902 [WEEX-139][ios]Provide system language infomation Provide locale module, contains information about system language. Example: [http://dotwe.org/vue/fc5e91d6f1a809bab2f073af53f4dd94] You

[GitHub] incubator-weex pull request #901: [WEEX-137][iOS] support iPhone X safe area...

2017-11-22 Thread CYJB
Github user CYJB commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/901#discussion_r152569045 --- Diff: ios/sdk/WeexSDK/Sources/Module/WXMetaModule.m --- @@ -42,6 +43,31 @@ - (void)setViewport:(NSDictionary *)viewportArguments } else

[GitHub] incubator-weex pull request #901: [WEEX-137][iOS] support iPhone X safe area...

2017-11-22 Thread CYJB
Github user CYJB commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/901#discussion_r152569002 --- Diff: ios/sdk/WeexSDK/Sources/Module/WXMetaModule.m --- @@ -42,6 +43,31 @@ - (void)setViewport:(NSDictionary *)viewportArguments } else

[GitHub] incubator-weex pull request #896: [WEEX-131][ios]URL property in error event...

2017-11-21 Thread CYJB
GitHub user CYJB opened a pull request: https://github.com/apache/incubator-weex/pull/896 [WEEX-131][ios]URL property in error event of web component may not be the real URL, fix it. [WEEX-131][ios]URL property in error event of web component may not be the real URL, fix it

[GitHub] incubator-weex pull request #848: [WEEX-100][iOS] Support customize button t...

2017-11-21 Thread CYJB
Github user CYJB closed the pull request at: https://github.com/apache/incubator-weex/pull/848 ---

[GitHub] incubator-weex pull request #895: [WEEX-131][ios]Fix url property in error e...

2017-11-21 Thread CYJB
Github user CYJB closed the pull request at: https://github.com/apache/incubator-weex/pull/895 ---

[GitHub] incubator-weex pull request #895: [WEEX-131][ios]Fix url property in error e...

2017-11-21 Thread CYJB
GitHub user CYJB opened a pull request: https://github.com/apache/incubator-weex/pull/895 [WEEX-131][ios]Fix url property in error event of web component may not be the real URL. [WEEX-131][ios]Fix url property in error event of web component may not be the real URL. In

[GitHub] incubator-weex pull request #885: [WEEX-131][test]Fix test failed of web com...

2017-11-21 Thread CYJB
Github user CYJB closed the pull request at: https://github.com/apache/incubator-weex/pull/885 ---

[GitHub] incubator-weex pull request #885: [WEEX-131][test]Fix test failed of web com...

2017-11-17 Thread CYJB
GitHub user CYJB opened a pull request: https://github.com/apache/incubator-weex/pull/885 [WEEX-131][test]Fix test failed of web component, http://www.error.com exists now. Test failed of web component because the error URL http://www.error.com exists now. Changed the error

[GitHub] incubator-weex pull request #848: [WEEX-100][iOS] Support customize button t...

2017-11-09 Thread CYJB
GitHub user CYJB opened a pull request: https://github.com/apache/incubator-weex/pull/848 [WEEX-100][iOS] Support customize button title for picker module Picker module support customizes button title by `confirmTitle` option and `cancelTitle` option. Bug: 100 You can

[GitHub] incubator-weex pull request #380: [ios] filter dom module methods

2017-05-22 Thread CYJB
Github user CYJB closed the pull request at: https://github.com/apache/incubator-weex/pull/380 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-weex pull request #380: [ios] filter dom module methods

2017-05-22 Thread CYJB
GitHub user CYJB opened a pull request: https://github.com/apache/incubator-weex/pull/380 [ios] filter dom module methods [ios] filter dom module methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/CYJB/incubator-weex 0.13

[GitHub] incubator-weex pull request #325: * [ios] Add Module invoke monitor

2017-05-08 Thread CYJB
GitHub user CYJB opened a pull request: https://github.com/apache/incubator-weex/pull/325 * [ios] Add Module invoke monitor Add Module invoke monitor You can merge this pull request into a Git repository by running: $ git pull https://github.com/CYJB/incubator-weex 0.13-dev